content/browser/frame_host/navigation_entry_impl.h - Issue 2136873002: Clear child FrameNavigationEntries if a history navigation redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 2136873002: Clear child FrameNavigationEntries if a history navigation redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable test on PlzNavigate. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_browsertest.cc ('k') | content/browser/frame_host/navigation_entry_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_entry_impl.h

diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h

index c8dd72237c14e525fd19a0eb2bfe4e8fe37a204b..442b134b157ca6ba4cf1f740868d46c9eb108976 100644

--- a/content/browser/frame_host/navigation_entry_impl.h

+++ b/content/browser/frame_host/navigation_entry_impl.h

@@ -217,6 +217,11 @@ class CONTENT_EXPORT NavigationEntryImpl

// there is one in this NavigationEntry.

FrameNavigationEntry* GetFrameEntry(FrameTreeNode* frame_tree_node) const;

+ // Removes subframe FrameNavigationEntries below the item corresponding to

+ // |frame_tree_node| (if any). This is necessary after server redirects

+ // during session history navigations, when the child items no longer apply.

+ void ClearChildren(FrameTreeNode* frame_tree_node);

void set_unique_id(int unique_id) {

unique_id_ = unique_id;

}