Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/analyzer/lib/src/task/incremental_element_builder.dart

Issue 2136853002: Adding/removing 'abstract' keyword is not a class delta change. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/incremental_element_builder_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/incremental_element_builder.dart
diff --git a/pkg/analyzer/lib/src/task/incremental_element_builder.dart b/pkg/analyzer/lib/src/task/incremental_element_builder.dart
index 0fba8e2974d555236e004dcd52e04eedd4f86eb3..65de1a56c172dc04dea30e692fb500dc0edd8f36 100644
--- a/pkg/analyzer/lib/src/task/incremental_element_builder.dart
+++ b/pkg/analyzer/lib/src/task/incremental_element_builder.dart
@@ -155,7 +155,9 @@ class IncrementalCompilationUnitElementBuilder {
ClassDeclaration oldClass, ClassDeclaration newClass) {
// If the class hierarchy or type parameters are changed,
// then the class changed too much - don't compute the delta.
- if (TokenUtils.getFullCode(newClass.typeParameters) !=
+ if (newClass.abstractKeyword != null && oldClass.abstractKeyword == null ||
+ newClass.abstractKeyword == null && oldClass.abstractKeyword != null ||
+ TokenUtils.getFullCode(newClass.typeParameters) !=
TokenUtils.getFullCode(oldClass.typeParameters) ||
TokenUtils.getFullCode(newClass.extendsClause) !=
TokenUtils.getFullCode(oldClass.extendsClause) ||
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/incremental_element_builder_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698