Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2136853002: Adding/removing 'abstract' keyword is not a class delta change. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adding/removing 'abstract' keyword is not a class delta change. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/98bb50599b322eeafd7ecd08400f8af21bc2910d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-10 18:26:36 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-11 13:52:59 UTC) #2
scheglov
4 years, 5 months ago (2016-07-11 16:09:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
98bb50599b322eeafd7ecd08400f8af21bc2910d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698