Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2136833003: service worker: Enable ServiceWorkerBlackBoxBrowserTest.Registration on cros (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
shimazu
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Enable ServiceWorkerBlackBoxBrowserTest.Registration on cros It was blocked on https://crbug.com/274855 which is now fixed. BUG=387045 Committed: https://crrev.com/7df022f863206400f2fbe0bde44a43348c191a7e Cr-Commit-Position: refs/heads/master@{#404601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
falken
ptal
4 years, 5 months ago (2016-07-11 02:28:59 UTC) #2
shimazu
On 2016/07/11 02:28:59, falken wrote: > ptal lgtm
4 years, 5 months ago (2016-07-11 04:44:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136833003/1
4 years, 5 months ago (2016-07-11 04:47:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 05:53:43 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 05:53:48 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 05:54:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7df022f863206400f2fbe0bde44a43348c191a7e
Cr-Commit-Position: refs/heads/master@{#404601}

Powered by Google App Engine
This is Rietveld 408576698