Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/dns/dns_client.cc

Issue 21368005: Detect domain-specific resolvers on OS X and disable DnsClient in such cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed nits Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/net/dns_probe_service.cc ('K') | « net/base/net_log_event_type_list.h ('k') | net/dns/dns_config_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_client.cc
diff --git a/net/dns/dns_client.cc b/net/dns/dns_client.cc
index 976f1533905112d21097fff65187eafc973e1224..9e29ca4265d0a5c2332cbfcb0e371bc5d222f56c 100644
--- a/net/dns/dns_client.cc
+++ b/net/dns/dns_client.cc
@@ -27,7 +27,7 @@ class DnsClientImpl : public DnsClient {
virtual void SetConfig(const DnsConfig& config) OVERRIDE {
factory_.reset();
session_ = NULL;
- if (config.IsValid()) {
+ if (config.IsValid() && !config.unhandled_options) {
ClientSocketFactory* factory = ClientSocketFactory::GetDefaultFactory();
scoped_ptr<DnsSocketPool> socket_pool(
config.randomize_ports ? DnsSocketPool::CreateDefault(factory)
« chrome/browser/net/dns_probe_service.cc ('K') | « net/base/net_log_event_type_list.h ('k') | net/dns/dns_config_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698