third_party/apple_dnsinfo/README.chromium - Issue 21368005: Detect domain-specific resolvers on OS X and disable DnsClient in such cases.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/apple_dnsinfo/README.chromium

Issue 21368005: Detect domain-specific resolvers on OS X and disable DnsClient in such cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add unhandled_options to NetLog Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 Name: Selected headers for System Configuration Daemon

	2 Short Name: configd

	3 URL: http://opensource.apple.com/source/configd/

	4 Version: 395.7

	5 License: Apple Public Source License 2.0

	6 Security Critical: yes

	7

	8 Description:

	9 Provides dns_config_t which is used by /net/dns/dns_config_service_posix.cc to
	Mark Mentovai 2013/08/06 15:41:00 Since all you need is the definition of a struct, Since all you need is the definition of a struct, you could handle this by just defining the struct inline in your own code. There is precedent for doing this in Chrome code, and it’s much easier and ligher-weight than having to bring in a whole new third_party thing for just one silly header. However, there’s also precedent for using third_party for this, enough so that we already have a directory for such code. If you opt to keep this header in third_party, place it in third_party/apple_apsl, and update the README.chromium in that directory in the same manner as the entries that are already there. szym 2013/08/06 17:50:25 Done. Moved to apple_apsl. Show quoted text On 2013/08/06 15:41:00, Mark Mentovai wrote: > Since all you need is the definition of a struct, you could handle this by just > defining the struct inline in your own code. There is precedent for doing this > in Chrome code, and it’s much easier and ligher-weight than having to bring in a > whole new third_party thing for just one silly header. > > However, there’s also precedent for using third_party for this, enough so that > we already have a directory for such code. If you opt to keep this header in > third_party, place it in third_party/apple_apsl, and update the README.chromium > in that directory in the same manner as the entries that are already there. Done. Moved to apple_apsl.
	10 obtain system DNS configuration on Mac OS X.

	11

	12 Local Modifications:

	13 None.

OLD	NEW

« net/dns/dns_config_service_posix.cc ('K') | « third_party/apple_dnsinfo/OWNERS ('k') | third_party/apple_dnsinfo/dnsinfo.h » ('j') | third_party/apple_dnsinfo/dnsinfo.h » ('J')