|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by nednguyen Modified:
4 years, 5 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase
This class currently has the same name with gpu_test_base.TestBase which
will cause breakage once https://codereview.chromium.org/2075743002/ is landed.
NOTRY=true
BUG=627204
Committed: https://crrev.com/a579f48e9c2266a5e0751ddb6e7ecf41accaa653
Cr-Commit-Position: refs/heads/master@{#404809}
Patch Set 1 #
Messages
Total messages: 30 (17 generated)
Description was changed from ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. ========== to ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
nednguyen@google.com changed reviewers: + kbr@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
LGTM Please reference a bug ID in the CL description. Thanks.
Description was changed from ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. BUG=627204 ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. BUG=627204 ========== to ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. NOTRY=true BUG=627204 ==========
On 2016/07/12 14:15:53, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Added NOTRY=true because browser_tests keep failing (cbrug.com/627467). All other gpu related tests are passing.
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. NOTRY=true BUG=627204 ========== to ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. NOTRY=true BUG=627204 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. NOTRY=true BUG=627204 ========== to ========== [content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase This class currently has the same name with gpu_test_base.TestBase which will cause breakage once https://codereview.chromium.org/2075743002/ is landed. NOTRY=true BUG=627204 Committed: https://crrev.com/a579f48e9c2266a5e0751ddb6e7ecf41accaa653 Cr-Commit-Position: refs/heads/master@{#404809} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a579f48e9c2266a5e0751ddb6e7ecf41accaa653 Cr-Commit-Position: refs/heads/master@{#404809} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
