DevTools: Sort execution contexts in nested frames

third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.Object}
  */
@@ skipping 178 matching lines @@
      * @param {!InspectorBackendClass.Connection} connection
      * @param {?WebInspector.Target} parentTarget
      * @return {!WebInspector.Target}
      */
     createTarget: function(name, type, connection, parentTarget)
     {
         var target = new WebInspector.Target(this, name, type, connection, parentTarget);
 
         /** @type {!WebInspector.ConsoleModel} */
         target.consoleModel = new WebInspector.ConsoleModel(target);
+        /** @type {!WebInspector.RuntimeModel} */
+        target.runtimeModel = new WebInspector.RuntimeModel(target);

[pfeldman, 2016/10/14 14:36:25]

With this, we broke one of the decorator assumptions - upon context creation, we
receive the frameId that has not been reported to the front-end (we initialize
resourceTreeModel below). This results in blank execution context names. Do you
remember why we moved it here?

[einbinder, 2016/10/14 18:07:38]

The ResourceTreeModel injects a callback into the runtimeModel for sorting
execution contexts by frames. 

 
         var networkManager = null;
         if (!target.isJSInspector())
             networkManager = new WebInspector.NetworkManager(target);
 
         /** @type {!WebInspector.ResourceTreeModel} */
         target.resourceTreeModel = new WebInspector.ResourceTreeModel(target, networkManager);
 
         if (networkManager)
             new WebInspector.NetworkLog(target, networkManager);
 
-        /** @type {!WebInspector.RuntimeModel} */
-        target.runtimeModel = new WebInspector.RuntimeModel(target);
         if (target.hasJSContext())
             new WebInspector.DebuggerModel(target);
 
         if (target.type() === WebInspector.Target.Type.Page) {
             new WebInspector.DOMModel(target);
             new WebInspector.CSSModel(target);
         }
 
         /** @type {?WebInspector.WorkerManager} */
         target.workerManager = target.supportsWorkers() ? new WebInspector.WorkerManager(target) : null;
@@ skipping 158 matching lines @@
     /**
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target) { },
 }
 
 /**
  * @type {!WebInspector.TargetManager}
  */
 WebInspector.targetManager = new WebInspector.TargetManager();