DevTools: Sort execution contexts in nested frames

third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
     this._agent.enable();
 
     this._fetchResourceTree();
 
     target.registerPageDispatcher(new WebInspector.PageDispatcher(this));
 
     this._securityOriginFrameCount = {};
     this._inspectedPageURL = "";
     this._pendingReloadOptions = null;
     this._reloadSuspensionCount = 0;
+
+    target.runtimeModel.setExecutionContextComparator(this._executionContextComparator.bind(this));
 }
 
 WebInspector.ResourceTreeModel.EventTypes = {
     FrameAdded: "FrameAdded",
     FrameNavigated: "FrameNavigated",
     FrameDetached: "FrameDetached",
     FrameResized: "FrameResized",
     FrameWillNavigate: "FrameWillNavigate",
     MainFrameNavigated: "MainFrameNavigated",
     ResourceAdded: "ResourceAdded",
@@ skipping 411 matching lines @@
          */
         function myCallback(protocolError, url, errors, data)
         {
             if (protocolError) {
                 callback(url, null, []);
                 return;
             }
             callback(url, data || null, errors);
         }
     },
+    /**
+     * @param {!WebInspector.ExecutionContext} a
+     * @param {!WebInspector.ExecutionContext} b
+     * @return {number}
+     */
+    _executionContextComparator: function(a,b)
+    {
+        var frameParents = function(frameId)

[pfeldman, 2016/07/09 02:02:08]

We used annotated named functions:

/**
 * @param {string} frameId
 */
function frameParents()
{
    ...
}

[einbinder, 2016/07/11 18:40:14]

Done.

+        {
+            var frame = this.frameForId(frameId)
+            var parents = [];
+            while (frame) {
+                parents.unshift(frame);

[pfeldman, 2016/07/09 02:02:09]

You should reverse the order and push instead - it is cheaper.

[einbinder, 2016/07/11 18:40:14]

Done.

+                frame = frame.parentFrame;
+            }
+            return parents;
+        }.bind(this);
+
+        var framesA = frameParents(a.frameId);

[pfeldman, 2016/07/09 02:02:08]

call it framePath ?

[einbinder, 2016/07/11 18:40:14]

Done.

+        var framesB = frameParents(b.frameId);
+        var frameA;
+        var frameB;
+        for (var i = 0; ; i++) {
+            if (!framesA[i] || !framesB[i] || (framesA[i] !== framesB[i])) {
+                frameA = framesA[i];
+                frameB = framesB[i];
+                break;
+            }
+        }
+        if (!frameA && frameB)
+            return -1;
+
+        if (!frameB && frameA)
+            return 1;
+
+        if (frameA && frameB) {
+            var frameIdDiff = String.hashCode(frameA.id) - String.hashCode(frameB.id);

[pfeldman, 2016/07/09 02:02:08]

You can use localeCompare here - it should not be slower.

[einbinder, 2016/07/11 18:40:14]

Done.

+            return frameIdDiff;
+        }
+        return WebInspector.ExecutionContext.comparator(a,b);
+    },
 
     __proto__: WebInspector.SDKModel.prototype
 }
 
 /**
  * @constructor
  * @param {!WebInspector.ResourceTreeModel} model
  * @param {?WebInspector.ResourceTreeFrame} parentFrame
  * @param {!PageAgent.FrameId} frameId
  * @param {!PageAgent.Frame=} payload
@@ skipping 427 matching lines @@
     },
 
     /**
      * @override
      */
     interstitialHidden: function()
     {
         // Frontend is not interested in interstitials.
     }
 }