ppapi/shared_impl/DEPS - Issue 2136743002: Simplify ppapi Graphics3D size propagation a bit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/shared_impl/DEPS

Issue 2136743002: Simplify ppapi Graphics3D size propagation a bit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_attr_parse_to_pepper

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base",	2 "+base",

3 "+gpu",	3 "+gpu",

4 "+media/audio",	4 "+media/audio",

5 "+media/base",	5 "+media/base",

6 "+skia",	6 "+skia",

	7 "+ui/gfx/geometry",
	erikchen 2016/07/09 01:14:55 When I was working on my change, I had plumbed gfx When I was working on my change, I had plumbed gfx::Size everywhere, and when I was finished realized it would require a DEPS change, so I abandoned the changes. :O piman 2016/07/09 01:19:35 Truth is, even after the DEPS thing, you'd certain Show quoted text On 2016/07/09 01:14:55, erikchen wrote: > When I was working on my change, I had plumbed gfx::Size everywhere, and when I > was finished realized it would require a DEPS change, so I abandoned the > changes. :O Truth is, even after the DEPS thing, you'd certainly have run into the nacl+gyp madness that would have made you run away screaming - see https://codereview.chromium.org/2104403003/ - so don't feel bad :)
7	8

8 "-ppapi/cpp",	9 "-ppapi/cpp",

9 "-ppapi/proxy",	10 "-ppapi/proxy",

10	11

11 # For testing purpose.	12 # For testing purpose.

12 "+ppapi/proxy/ppapi_proxy_test.h",	13 "+ppapi/proxy/ppapi_proxy_test.h",

13 ]	14 ]

OLD	NEW

« ppapi/proxy/ppb_graphics_3d_proxy.h ('K') | « ppapi/proxy/ppb_graphics_3d_proxy.cc ('k') | ppapi/shared_impl/ppb_graphics_3d_shared.h » ('j') | no next file with comments »