Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc

Issue 2136733002: Mojo C++ bindings: add a new mode to generator to use native STL/WTF types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@67_new
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc b/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc
index 9eb111bcb91c93107e155107045c415097885cdb..dcf2967bb5ba92f9b585de77e8e85c9624baeac4 100644
--- a/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc
@@ -119,12 +119,6 @@ TEST_F(SerializationWarningTest, StructInStruct) {
TEST_F(SerializationWarningTest, ArrayOfStructsInStruct) {
Struct4Ptr test_struct(Struct4::New());
- EXPECT_TRUE(!test_struct->data);
-
- TestWarning(std::move(test_struct),
- mojo::internal::VALIDATION_ERROR_UNEXPECTED_NULL_POINTER);
-
- test_struct = Struct4::New();
test_struct->data.resize(1);
TestWarning(std::move(test_struct),
@@ -144,12 +138,6 @@ TEST_F(SerializationWarningTest, ArrayOfStructsInStruct) {
TEST_F(SerializationWarningTest, FixedArrayOfStructsInStruct) {
Struct5Ptr test_struct(Struct5::New());
- EXPECT_TRUE(!test_struct->pair);
-
- TestWarning(std::move(test_struct),
- mojo::internal::VALIDATION_ERROR_UNEXPECTED_NULL_POINTER);
-
- test_struct = Struct5::New();
test_struct->pair.resize(1);
test_struct->pair[0] = Struct1::New();
@@ -164,19 +152,6 @@ TEST_F(SerializationWarningTest, FixedArrayOfStructsInStruct) {
TestWarning(std::move(test_struct), mojo::internal::VALIDATION_ERROR_NONE);
}
-TEST_F(SerializationWarningTest, StringInStruct) {
- Struct6Ptr test_struct(Struct6::New());
- EXPECT_TRUE(!test_struct->str);
-
- TestWarning(std::move(test_struct),
- mojo::internal::VALIDATION_ERROR_UNEXPECTED_NULL_POINTER);
-
- test_struct = Struct6::New();
- test_struct->str = "hello world";
-
- TestWarning(std::move(test_struct), mojo::internal::VALIDATION_ERROR_NONE);
-}
-
TEST_F(SerializationWarningTest, ArrayOfArraysOfHandles) {
Array<Array<ScopedHandle>> test_array = CreateTestNestedHandleArray();
test_array[0] = nullptr;
« no previous file with comments | « mojo/public/cpp/bindings/tests/sample_service_unittest.cc ('k') | mojo/public/cpp/bindings/tests/stl_converters_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698