Issue 213673005: Timeline: show selected event details in Tracing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213673005: Timeline: show selected event details in Tracing mode (Closed)

Created:
6 years, 8 months ago by caseq

Modified:
6 years, 8 months ago

Reviewers:
pfeldman, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: show selected event details in Tracing mode Also, highlight record on hover. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170581

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -3 lines)			Patch
M	Source/devtools/front_end/TimelineTracingView.js	View	5 chunks	+46 lines, -3 lines	1 comment	Download
M	Source/devtools/front_end/TracingModel.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/timelinePanel.css	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/213673005/diff/1/Source/devtools/front_end/TimelineTracingView.js File Source/devtools/front_end/TimelineTracingView.js (right): https://codereview.chromium.org/213673005/diff/1/Source/devtools/front_end/TimelineTracingView.js#newcode143 Source/devtools/front_end/TimelineTracingView.js:143: var table = document.createElement("table"); Is there a screenshot?

6 years, 8 months ago (2014-04-01 14:17:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/213673005/1

6 years, 8 months ago (2014-04-01 15:59:30 UTC) #4

Message was sent while issue was closed.

Change committed as 170581

Expand Messages | Collapse Messages