third_party/WebKit/Tools/Scripts/update-w3c-test-expections - Issue 2136723002: Create test expectations line automatically from failing test results

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/update-w3c-test-expections

Issue 2136723002: Create test expectations line automatically from failing test results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactored script to pass in Host object to main use its attributes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 #!/usr/bin/env python

	2 # Copyright 2016 The Chromium Authors. All rights reserved.

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6 import sys

	7

	8 from webkitpy.common import host

	9 from webkitpy.common.checkout.scm.git import Git

	10 from webkitpy.w3c.update_w3c_test_expectations import main

	11

	12 if __name__ == "__main__":

	13 _host = host.Host()

	14 _host._scm = Git('.')
	qyearsley 2016/07/18 22:55:28 It might also work if you call host.initialize_scm It might also work if you call host.initialize_scm() here -- in practice, I believe this should always set up a Git object as long as the current working directory is in a git repo.
	15 _port = _host.port_factory.get()
	qyearsley 2016/07/18 22:55:28 No need to use underscores here, since these are l No need to use underscores here, since these are local variables, not attributes of a class.
	16 return_code = main(_host, _port)

	17

	18 sys.exit(return_code)

OLD	NEW