Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 21367002: Zero terminate script names generated by js2c. (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Zero terminate script names generated by js2c. In bootstrapper.cc we directly pass the pointer to the start of these vectors to strcmp. Zero-terminating the strings will make them actually suitable for being passed to strcmp. BUG=none R=jkummerow@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/js2c.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-07-31 13:46:49 UTC) #1
Jakob Kummerow
7 years, 4 months ago (2013-08-01 09:49:24 UTC) #2
Message was sent while issue was closed.
As discussed, I don't really see the point of this change.

Powered by Google App Engine
This is Rietveld 408576698