Issue 21367002: Zero terminate script names generated by js2c.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21367002: Zero terminate script names generated by js2c. (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Zero terminate script names generated by js2c. In bootstrapper.cc we directly pass the pointer to the start of these vectors to strcmp. Zero-terminating the strings will make them actually suitable for being passed to strcmp. BUG=none R=jkummerow@chromium.org

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/js2c.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

7 years, 4 months ago (2013-08-01 09:49:24 UTC) #2

Message was sent while issue was closed.

As discussed, I don't really see the point of this change.

Expand Messages | Collapse Messages