Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2136693002:
Minor updates for main() (Closed)
|
Created:
4 years, 5 months ago by Mark Mentovai Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMinor updates for main()
Use const where it's sensible. Update a couple of format strings.
R=kerrnel@chromium.org
TBR=grt@chromium.org
Committed: https://crrev.com/5aaed6b414ba01998232325e3392a934b4faa4eb
Cr-Commit-Position: refs/heads/master@{#404519}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
mark@chromium.org changed reviewers: + kerrnel@chromium.org
On 2016/07/08 21:41:35, Mark Mentovai wrote: LGTM
The CQ bit was checked by mark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Minor updates for main() Use const where it's sensible. Update a couple of format strings. ========== to ========== Minor updates for main() Use const where it's sensible. Update a couple of format strings. R=kerrnel@chromium.org TBR=grt@chromium.org ==========
mark@chromium.org changed reviewers: + grt@chromium.org
+grt for OWNERS. TBR because he’s away, and the other owner, cpu, is effectively emeritus.
The CQ bit was checked by mark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Minor updates for main() Use const where it's sensible. Update a couple of format strings. R=kerrnel@chromium.org TBR=grt@chromium.org ========== to ========== Minor updates for main() Use const where it's sensible. Update a couple of format strings. R=kerrnel@chromium.org TBR=grt@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Minor updates for main() Use const where it's sensible. Update a couple of format strings. R=kerrnel@chromium.org TBR=grt@chromium.org ========== to ========== Minor updates for main() Use const where it's sensible. Update a couple of format strings. R=kerrnel@chromium.org TBR=grt@chromium.org Committed: https://crrev.com/5aaed6b414ba01998232325e3392a934b4faa4eb Cr-Commit-Position: refs/heads/master@{#404519} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5aaed6b414ba01998232325e3392a934b4faa4eb Cr-Commit-Position: refs/heads/master@{#404519} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
