Issue 2136683002: Use smart pointers for class owned member variables

Issue 2136683002: Use smart pointers for class owned member variables (Closed)

Created:
4 years, 5 months ago by Wei Li

Modified:
4 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Use smart pointers for class owned member variables Replace raw member variables to smart pointer type to better maintain the ownership and to ease the management. BUG=pdfium:518 Committed: https://pdfium.googlesource.com/pdfium/+/5a6c1398d0e559fb6a048cb0dca46ba9f9309a77

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+171 lines, -142 lines)			Patch
M	BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	core/fpdfapi/fpdf_parser/cpdf_parser.cpp	View	9 chunks	+10 lines, -11 lines	0 comments	Download
M	core/fpdfapi/fpdf_parser/include/cpdf_parser.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fpdfapi/fpdf_render/fpdf_render_image.cpp	View	9 chunks	+13 lines, -12 lines	0 comments	Download
M	core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View	1 chunk	+14 lines, -13 lines	0 comments	Download
M	core/fpdfapi/fpdf_render/render_int.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	core/fpdfdoc/cpdf_variabletext.cpp	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	core/fpdfdoc/cpvt_sectioninfo.h	View	1 chunk	+9 lines, -34 lines	0 comments	Download
A	core/fpdfdoc/cpvt_sectioninfo.cpp	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	core/fpdfdoc/cpvt_wordinfo.h	View	2 chunks	+8 lines, -45 lines	0 comments	Download
A	core/fpdfdoc/cpvt_wordinfo.cpp	View	1 chunk	+54 lines, -0 lines	0 comments	Download
M	core/fpdfdoc/doc_annot.cpp	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	core/fpdfdoc/include/fpdf_doc.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	fpdfsdk/fsdk_mgr.cpp	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 8 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136683002/20001

4 years, 5 months ago (2016-07-11 21:32:04 UTC) #6

commit-bot: I haz the power

4 years, 5 months ago (2016-07-11 21:43:45 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/5a6c1398d0e559fb6a048cb0dca46ba9f930...