Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2136643002: Revert of Add choke point for modifying non-AA rect draws (e.g., applying clipping) (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add choke point for modifying non-AA rect draws (e.g., applying clipping) (patchset #6 id:100001 of https://codereview.chromium.org/2125333002/ ) Reason for revert: problems Original issue's description: > Add choke point for modifying non-AA rect draws (e.g., applying clipping) > > NOTREECHECKS=true > NOPRESUBMIT=true > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002 > > Committed: https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9a4cfa81de1f485c630785eef5e305c60faab80a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -117 lines) Patch
M include/gpu/GrDrawContext.h View 2 chunks +4 lines, -14 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 11 chunks +70 lines, -95 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
Created Revert of Add choke point for modifying non-AA rect draws (e.g., applying clipping)
4 years, 5 months ago (2016-07-08 20:29:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136643002/1
4 years, 5 months ago (2016-07-08 20:29:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9a4cfa81de1f485c630785eef5e305c60faab80a
4 years, 5 months ago (2016-07-08 20:30:09 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 20:30:12 UTC) #6
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698