Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2136513002: Setting AudioOutputDevice authorization timeout to 1000ms (Closed)

Created:
4 years, 5 months ago by o1ka
Modified:
4 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Setting AudioOutputDevice authorization timeout to 1000ms There is an ongoing discussion in https://codereview.chromium.org/2121223002/ regarding timeout values and UMA stats for those. Meanwhile, increasing the timeout from 900ms to 1000ms since 900ms is too strict: according to the latest UMA stats 0.4% of authorizations time out. Landing this will allow us to gather some stats at least. BUG=615589 Committed: https://crrev.com/bd9ad97e1da5d2084b76ea929ab755902922d9fc Cr-Commit-Position: refs/heads/master@{#404399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/audio_device_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
o1ka
Tommi, PTAL
4 years, 5 months ago (2016-07-08 12:16:01 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 5 months ago (2016-07-08 13:16:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136513002/1
4 years, 5 months ago (2016-07-08 13:23:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 15:56:04 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 15:56:11 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 15:57:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd9ad97e1da5d2084b76ea929ab755902922d9fc
Cr-Commit-Position: refs/heads/master@{#404399}

Powered by Google App Engine
This is Rietveld 408576698