[Autofill] Improve support for various credit card expiration dates.

components/autofill/core/browser/credit_card_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/guid.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 149 matching lines @@
   // Result of assignment should be logically equal to the original profile.
   CreditCard b(base::GenerateGUID(), "some other origin");
   b = a;
   EXPECT_TRUE(a == b);
 
   // Assignment to self should not change the profile value.
   a = a;
   EXPECT_TRUE(a == b);
 }
 
+TEST(CreditCardTest, SetExpirationYearFromString) {

[sebsg, 2016/07/08 10:01:45]

Can you add tests for 

1 year digit
3 year digits
string with characters

Thanks!

[Mathieu, 2016/07/08 14:27:05]

Done.

+  CreditCard a(base::GenerateGUID(), "some origin");
+  a.SetExpirationYearFromString(ASCIIToUTF16("2040"));
+  EXPECT_EQ(2040, a.expiration_year());
+
+  // Test will fail in 2100 (!).
+  CreditCard b(base::GenerateGUID(), "some origin");
+  b.SetExpirationYearFromString(ASCIIToUTF16("45"));
+  EXPECT_EQ(2045, b.expiration_year());
+
+  // Invalid value.
+  CreditCard c(base::GenerateGUID(), "some origin");
+  c.SetExpirationYearFromString(ASCIIToUTF16("052045"));
+  EXPECT_EQ(0, c.expiration_year());
+}
+
+TEST(CreditCardTest, SetExpirationDateFromString) {

[sebsg, 2016/07/08 10:01:45]

Can you add an example with multiple separators? And an example with invalid
values and separator?

ex: 05-/2045
    May-2045
    05_2045
    etc

[Mathieu, 2016/07/08 14:27:05]

Done.

+  CreditCard a(base::GenerateGUID(), "some origin");
+  a.SetExpirationDateFromString(ASCIIToUTF16("052045"));

[sebsg, 2016/07/08 10:01:45]

Can you put all the cases with no separator together? It will be easier to see
they are all covered.

myy
mmyy
myyyy
mmyyyy

Thanks!

[Mathieu, 2016/07/08 14:27:05]

Done.

+  EXPECT_EQ(2045, a.expiration_year());
+  EXPECT_EQ(5, a.expiration_month());
+
+  CreditCard b(base::GenerateGUID(), "some origin");
+  b.SetExpirationDateFromString(ASCIIToUTF16("05/45"));
+  EXPECT_EQ(2045, b.expiration_year());
+  EXPECT_EQ(5, b.expiration_month());
+
+  CreditCard c(base::GenerateGUID(), "some origin");
+  c.SetExpirationDateFromString(ASCIIToUTF16("05/2045"));
+  EXPECT_EQ(2045, c.expiration_year());
+  EXPECT_EQ(5, c.expiration_month());
+
+  CreditCard d(base::GenerateGUID(), "some origin");
+  d.SetExpirationDateFromString(ASCIIToUTF16("0545"));
+  EXPECT_EQ(2045, d.expiration_year());
+  EXPECT_EQ(5, d.expiration_month());
+
+  CreditCard e(base::GenerateGUID(), "some origin");
+  e.SetExpirationDateFromString(ASCIIToUTF16("05-45"));
+  EXPECT_EQ(2045, e.expiration_year());
+  EXPECT_EQ(5, e.expiration_month());
+
+  CreditCard f(base::GenerateGUID(), "some origin");
+  f.SetExpirationDateFromString(ASCIIToUTF16("05-2045"));
+  EXPECT_EQ(2045, f.expiration_year());
+  EXPECT_EQ(5, f.expiration_month());
+
+  CreditCard g(base::GenerateGUID(), "some origin");
+  g.SetExpirationDateFromString(ASCIIToUTF16("05|45"));
+  EXPECT_EQ(2045, g.expiration_year());
+  EXPECT_EQ(5, g.expiration_month());
+
+  CreditCard h(base::GenerateGUID(), "some origin");
+  h.SetExpirationDateFromString(ASCIIToUTF16("545"));
+  EXPECT_EQ(2045, h.expiration_year());
+  EXPECT_EQ(5, h.expiration_month());
+
+  CreditCard i(base::GenerateGUID(), "some origin");
+  i.SetExpirationDateFromString(ASCIIToUTF16("52045"));
+  EXPECT_EQ(2045, i.expiration_year());
+  EXPECT_EQ(5, i.expiration_month());
+
+  CreditCard j(base::GenerateGUID(), "some origin");
+  j.SetExpirationDateFromString(ASCIIToUTF16("5/2045"));
+  EXPECT_EQ(2045, j.expiration_year());
+  EXPECT_EQ(5, j.expiration_month());
+
+  CreditCard k(base::GenerateGUID(), "some origin");
+  k.SetExpirationDateFromString(ASCIIToUTF16("5-2045"));
+  EXPECT_EQ(2045, k.expiration_year());
+  EXPECT_EQ(5, k.expiration_month());
+
+  CreditCard l(base::GenerateGUID(), "some origin");
+  l.SetExpirationDateFromString(ASCIIToUTF16("5|2045"));
+  EXPECT_EQ(2045, l.expiration_year());
+  EXPECT_EQ(5, l.expiration_month());
+}
+
 TEST(CreditCardTest, Copy) {
   CreditCard a(base::GenerateGUID(), "https://www.example.com");
   test::SetCreditCardInfo(&a, "John Dillinger", "123456789012", "01", "2010");
 
   // Clone should be logically equal to the original.
   CreditCard b(a);
   EXPECT_TRUE(a == b);
 }
 
 TEST(CreditCardTest, IsLocalDuplicateOfServerCard) {
@@ skipping 646 matching lines @@
     card.set_record_type(kTestCases[i].record_type);
     if (card.record_type() != CreditCard::LOCAL_CARD)
       card.SetServerStatus(kTestCases[i].server_status);
 
     EXPECT_EQ(kTestCases[i].should_update_expiration,
               card.ShouldUpdateExpiration(now));
   }
 }
 
 }  // namespace autofill