Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2136423003: Merge M52: Add AntiVirus information to the system profile. (Closed)

Created:
4 years, 5 months ago by Will Harris
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge M52: Add AntiVirus information to the system profile. Collection happens after Google Update data has been collected and before drive metrics data, on the FILE thread. BUG=615154 TEST=unit_tests TEST=manual, check system profile contains AV information via logging. Review-Url: https://codereview.chromium.org/2009773007 Cr-Commit-Position: refs/heads/master@{#398597} (cherry picked from commit c768983fac1178f0219e1f7aab38200c7d87d8b4) Merge M52: Add support for obtaining AV products on Win7. Previously WSC API was used which is only available on Windows 8. This CL adds support via WMI, which is available from Vista onwards. BUG=615154 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/1e8be206b2e8a96af660720bef1450f8a06af167 Review-Url: https://codereview.chromium.org/2064313004 Cr-Original-Commit-Position: refs/heads/master@{#400496} Cr-Commit-Position: refs/heads/master@{#403544} (cherry picked from commit 6813e4fdd732d11c532c02fd07e16f6c76df78ab) Review URL: https://codereview.chromium.org/2132693002 . Cr-Commit-Position: refs/branch-heads/2785@{#43} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} (cherry picked from commit b75c31bb3974d9749085aad6f2420cf7e9d731af) Committed: https://chromium.googlesource.com/chromium/src/+/04f78ed689838121983aa7019f1744d188dd1ced

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+760 lines, -3 lines) Patch
A chrome/browser/metrics/antivirus_metrics_provider_win.h View 1 chunk +102 lines, -0 lines 0 comments Download
A chrome/browser/metrics/antivirus_metrics_provider_win.cc View 1 chunk +428 lines, -0 lines 0 comments Download
A chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc View 1 chunk +128 lines, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/proto/system_profile.proto View 2 chunks +40 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Will Harris
4 years, 5 months ago (2016-07-12 01:25:57 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
04f78ed689838121983aa7019f1744d188dd1ced.

Powered by Google App Engine
This is Rietveld 408576698