Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: cc/ipc/struct_traits_unittest.cc

Issue 2136413002: Update Surface ID Terminology (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix webkit_unit_tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/ipc/struct_traits_unittest.cc
diff --git a/cc/ipc/struct_traits_unittest.cc b/cc/ipc/struct_traits_unittest.cc
index f74f10ad7622a8353f3addf83f293bcfc1fa4da8..a85c7dbce11a97d3b3356ab7fd43877addc02d42 100644
--- a/cc/ipc/struct_traits_unittest.cc
+++ b/cc/ipc/struct_traits_unittest.cc
@@ -288,7 +288,7 @@ TEST_F(StructTraitsTest, CompositorFrameMetadata) {
std::vector<ui::LatencyInfo> latency_infos = {latency_info};
std::vector<uint32_t> satisfies_sequences = {1234, 1337};
std::vector<SurfaceId> referenced_surfaces;
- SurfaceId id(1234, 5678, 9101112);
+ SurfaceId id(2345, 1234, 5678, 9101112);
referenced_surfaces.push_back(id);
CompositorFrameMetadata input;
@@ -432,7 +432,7 @@ TEST_F(StructTraitsTest, QuadListBasic) {
solid_quad->SetNew(&sqs, rect2, rect2, color2, force_anti_aliasing_off);
const gfx::Rect rect3(1029, 3847, 5610, 2938);
- const SurfaceId surface_id(1234, 5678, 2468);
+ const SurfaceId surface_id(2345, 1234, 5678, 2468);
SurfaceDrawQuad* surface_quad = input.AllocateAndConstruct<SurfaceDrawQuad>();
surface_quad->SetNew(&sqs, rect3, rect3, surface_id);
@@ -602,7 +602,7 @@ TEST_F(StructTraitsTest, RenderPass) {
input->CreateAndAppendDrawQuad<SurfaceDrawQuad>();
const gfx::Rect surface_quad_rect(1337, 2448, 1234, 5678);
surface_quad->SetNew(shared_state_2, surface_quad_rect, surface_quad_rect,
- SurfaceId(1337, 1234, 2468));
+ SurfaceId(1234, 1337, 1234, 2468));
std::unique_ptr<RenderPass> output;
mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
@@ -729,26 +729,28 @@ TEST_F(StructTraitsTest, Selection) {
}
TEST_F(StructTraitsTest, SurfaceId) {
- const uint32_t id_namespace = 1337;
+ const uint32_t gpu_id = 1234;
+ const uint32_t client_id = 1337;
const uint32_t local_id = 0xfbadbeef;
const uint64_t nonce = 0xdeadbeef;
- SurfaceId input(id_namespace, local_id, nonce);
+ SurfaceId input(gpu_id, client_id, local_id, nonce);
mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
SurfaceId output;
proxy->EchoSurfaceId(input, &output);
- EXPECT_EQ(id_namespace, output.id_namespace());
+ EXPECT_EQ(gpu_id, output.gpu_id());
+ EXPECT_EQ(client_id, output.client_id());
EXPECT_EQ(local_id, output.local_id());
EXPECT_EQ(nonce, output.nonce());
}
TEST_F(StructTraitsTest, SurfaceSequence) {
- const uint32_t id_namespace = 2016;
+ const uint32_t client_id = 2016;
const uint32_t sequence = 0xfbadbeef;
- SurfaceSequence input(id_namespace, sequence);
+ SurfaceSequence input(client_id, sequence);
mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
SurfaceSequence output;
proxy->EchoSurfaceSequence(input, &output);
- EXPECT_EQ(id_namespace, output.id_namespace);
+ EXPECT_EQ(client_id, output.client_id);
EXPECT_EQ(sequence, output.sequence);
}

Powered by Google App Engine
This is Rietveld 408576698