Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2136413002: Update Surface ID Terminology (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed webkit_unit_tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 9be164eb9183f416e24c53a83bb12e9b0940458d..822b9e1fd68cf82ab056c426a94be35e3586e01a 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -48,7 +48,7 @@ RenderWidgetHostViewChildFrame::RenderWidgetHostViewChildFrame(
frame_connector_(nullptr),
begin_frame_source_(nullptr),
observing_begin_frame_source_(false),
- parent_surface_id_namespace_(0),
+ parent_surface_client_id_(0),
weak_factory_(this) {
id_allocator_ = CreateSurfaceIdAllocator();
RegisterSurfaceNamespaceId();
@@ -67,28 +67,28 @@ void RenderWidgetHostViewChildFrame::SetCrossProcessFrameConnector(
return;
if (frame_connector_) {
- if (parent_surface_id_namespace_) {
+ if (parent_surface_client_id_) {
GetSurfaceManager()->UnregisterSurfaceNamespaceHierarchy(
- parent_surface_id_namespace_, GetSurfaceIdNamespace());
+ parent_surface_client_id_, GetSurfaceClientId());
}
// Unregister the client here, as it is not guaranteed in tests that the
// destructor will be called.
GetSurfaceManager()->UnregisterSurfaceFactoryClient(
- id_allocator_->id_namespace());
+ id_allocator_->client_id());
- parent_surface_id_namespace_ = 0;
+ parent_surface_client_id_ = 0;
}
frame_connector_ = frame_connector;
if (frame_connector_) {
GetSurfaceManager()->RegisterSurfaceFactoryClient(
- id_allocator_->id_namespace(), this);
+ id_allocator_->client_id(), this);
RenderWidgetHostViewBase* parent_view =
frame_connector_->GetParentRenderWidgetHostView();
if (parent_view) {
- parent_surface_id_namespace_ = parent_view->GetSurfaceIdNamespace();
- DCHECK_NE(parent_surface_id_namespace_, 0u);
+ parent_surface_client_id_ = parent_view->GetSurfaceClientId();
+ DCHECK_NE(parent_surface_client_id_, 0u);
GetSurfaceManager()->RegisterSurfaceNamespaceHierarchy(
- parent_surface_id_namespace_, GetSurfaceIdNamespace());
+ parent_surface_client_id_, GetSurfaceClientId());
}
}
}
@@ -268,7 +268,7 @@ void RenderWidgetHostViewChildFrame::RenderProcessGone(
}
void RenderWidgetHostViewChildFrame::Destroy() {
- // SurfaceIdNamespaces registered with RenderWidgetHostInputEventRouter
+ // SurfaceClientIds registered with RenderWidgetHostInputEventRouter
// have already been cleared when RenderWidgetHostViewBase notified its
// observers of our impending destruction.
if (frame_connector_) {
@@ -310,16 +310,16 @@ void RenderWidgetHostViewChildFrame::RegisterSurfaceNamespaceId() {
if (host_ && host_->delegate() && host_->delegate()->GetInputEventRouter()) {
RenderWidgetHostInputEventRouter* router =
host_->delegate()->GetInputEventRouter();
- if (!router->is_registered(GetSurfaceIdNamespace()))
- router->AddSurfaceIdNamespaceOwner(GetSurfaceIdNamespace(), this);
+ if (!router->is_registered(GetSurfaceClientId()))
+ router->AddSurfaceClientIdOwner(GetSurfaceClientId(), this);
}
}
void RenderWidgetHostViewChildFrame::UnregisterSurfaceNamespaceId() {
DCHECK(host_);
if (host_->delegate() && host_->delegate()->GetInputEventRouter()) {
- host_->delegate()->GetInputEventRouter()->RemoveSurfaceIdNamespaceOwner(
- GetSurfaceIdNamespace());
+ host_->delegate()->GetInputEventRouter()->RemoveSurfaceClientIdOwner(
+ GetSurfaceClientId());
}
}
@@ -398,7 +398,7 @@ void RenderWidgetHostViewChildFrame::OnSwapCompositorFrame(
surface_factory_->Create(surface_id_);
cc::SurfaceSequence sequence = cc::SurfaceSequence(
- id_allocator_->id_namespace(), next_surface_sequence_++);
+ id_allocator_->client_id(), next_surface_sequence_++);
// The renderer process will satisfy this dependency when it creates a
// SurfaceLayer.
cc::SurfaceManager* manager = GetSurfaceManager();
@@ -479,8 +479,8 @@ bool RenderWidgetHostViewChildFrame::IsMouseLocked() {
return false;
}
-uint32_t RenderWidgetHostViewChildFrame::GetSurfaceIdNamespace() {
- return id_allocator_->id_namespace();
+uint32_t RenderWidgetHostViewChildFrame::GetSurfaceClientId() {
+ return id_allocator_->client_id();
}
void RenderWidgetHostViewChildFrame::ProcessKeyboardEvent(

Powered by Google App Engine
This is Rietveld 408576698