Make CharacterData.appendData() argument mandatory

Make CharacterData.appendData() argument mandatory

Make CharacterData.appendData() argument mandatory as per the latest specification:
http://dom.spec.whatwg.org/#characterdata

This behavior is consistent with IE10 and Firefox.

BUG=266351
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155323

[arv (Not doing code reviews), 2013-07-31 15:40:11]

LGTM

[haraken, 2013-07-31 16:04:26]

LGTM

I'm not sure about what kind of IDL changes require API review and what kind of
changes don't. My impression is that adding/removing APIs or modifying APIs
whose behaviors are not consistent in other browsers would require API review.
On the other hand, trivial modification (changing behavior about missing
arguments, null, undefined, various edge cases) about APIs whose behaviors are
consistent in other browsers and the spec wouldn't require API review.

Regarding this CL, I'm not sure if it's trivial or not. The CL is going to throw
exceptions for code that hasn't thrown exceptions, which might have
backward-compatibility concern.

(I'm sorry for blocking you from landing the CL.)

https://codereview.chromium.org/21364003/diff/1/LayoutTests/fast/dom/characte...
File LayoutTests/fast/dom/characterdata-appendData-argument.html (right):

https://codereview.chromium.org/21364003/diff/1/LayoutTests/fast/dom/characte...
LayoutTests/fast/dom/characterdata-appendData-argument.html:12:
shouldBe("text.data", "'abcd'");

Nit: You can use shouldBeEqualToString()

https://codereview.chromium.org/21364003/diff/1/LayoutTests/fast/dom/characte...
LayoutTests/fast/dom/characterdata-appendData-argument.html:15:
shouldBe("text.data", "'abcdefg'");

Ditto.

https://codereview.chromium.org/21364003/diff/1/LayoutTests/fast/dom/characte...
LayoutTests/fast/dom/characterdata-appendData-argument.html:17:
shouldBe("text.data", "'abcdefg'");

Ditto.

[do-not-use, 2013-07-31 17:09:04]

On 2013/07/31 16:04:26, haraken wrote:
> LGTM
> 
> I'm not sure about what kind of IDL changes require API review and what kind
of
> changes don't. My impression is that adding/removing APIs or modifying APIs
> whose behaviors are not consistent in other browsers would require API review.
> On the other hand, trivial modification (changing behavior about missing
> arguments, null, undefined, various edge cases) about APIs whose behaviors are
> consistent in other browsers and the spec wouldn't require API review.
> 
> Regarding this CL, I'm not sure if it's trivial or not. The CL is going to
throw
> exceptions for code that hasn't thrown exceptions, which might have
> backward-compatibility concern.

Sure, let's wait for approval from an API owner.

For the record, I believe the compatibility risk is low even throw we start
throwing because:
1. Firefox and IE already behave this way.
2. This is a corner case and it is unlikely a website would call appendData()
with no argument.

[tkent, 2013-07-31 21:39:06]

lgtm.

The intention of Source/OWNER is that any web-exposed IDL changes should be
reviewed by an API owner.

[commit-bot: I haz the power, 2013-08-01 05:30:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21364003/7001

[commit-bot: I haz the power, 2013-08-01 09:32:39]

Change committed as 155323