chrome/browser/browsing_data/browsing_data_counter_factory.cc - Issue 2136373003: Move browsing data deletion prefs to components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_counter_factory.cc

Issue 2136373003: Move browsing data deletion prefs to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/autofill_counter_browsertest.cc ('k') | chrome/browser/browsing_data/browsing_data_counter_utils.cc » ('j') | components/browsing_data/pref_names.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_counter_factory.cc

diff --git a/chrome/browser/browsing_data/browsing_data_counter_factory.cc b/chrome/browser/browsing_data/browsing_data_counter_factory.cc

index 631460007401ff2db2c1adf4ca0ed797b50fa73d..40a749b1bdd680de46293c0a10074392cd712bc8 100644

--- a/chrome/browser/browsing_data/browsing_data_counter_factory.cc

+++ b/chrome/browser/browsing_data/browsing_data_counter_factory.cc

@@ -13,8 +13,8 @@

#include "chrome/browser/browsing_data/media_licenses_counter.h"

#include "chrome/browser/browsing_data/passwords_counter.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/common/pref_names.h"

#include "components/browsing_data/counters/browsing_data_counter.h"

+#include "components/browsing_data/pref_names.h"

#if defined(ENABLE_EXTENSIONS)

#include "chrome/browser/browsing_data/hosted_apps_counter.h"

@@ -27,26 +27,26 @@ BrowsingDataCounterFactory::GetForProfileAndPref(Profile* profile,

if (!AreCountersEnabled())

return nullptr;

- if (pref_name == prefs::kDeleteBrowsingHistory)

+ if (pref_name == browsing_data::prefs::kDeleteBrowsingHistory)

return base::MakeUnique<HistoryCounter>(profile);

- if (pref_name == prefs::kDeleteCache)

+ if (pref_name == browsing_data::prefs::kDeleteCache)

return base::MakeUnique<CacheCounter>(profile);

- if (pref_name == prefs::kDeletePasswords)

+ if (pref_name == browsing_data::prefs::kDeletePasswords)

return base::MakeUnique<PasswordsCounter>(profile);

- if (pref_name == prefs::kDeleteFormData)

+ if (pref_name == browsing_data::prefs::kDeleteFormData)

return base::MakeUnique<AutofillCounter>(profile);

- if (pref_name == prefs::kDeleteDownloadHistory)

+ if (pref_name == browsing_data::prefs::kDeleteDownloadHistory)

return base::MakeUnique<DownloadsCounter>(profile);

- if (pref_name == prefs::kDeleteMediaLicenses)

+ if (pref_name == browsing_data::prefs::kDeleteMediaLicenses)

return base::MakeUnique<MediaLicensesCounter>(profile);

#if defined(ENABLE_EXTENSIONS)

- if (pref_name == prefs::kDeleteHostedAppsData)

+ if (pref_name == browsing_data::prefs::kDeleteHostedAppsData)

return base::MakeUnique<HostedAppsCounter>(profile);

#endif