Move browsing data deletion prefs to components

Move browsing data deletion prefs to components

Move the pref_names related to browsing data deletion from chrome/common/ to components/browsing_data. They will be needed in the componentized counters.

BUG=620317
Committed: https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a
Cr-Commit-Position: refs/heads/master@{#405123}

[ioanap, 2016-07-12 11:04:57]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 11:05:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 11:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 11:17:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ioanap, 2016-07-12 12:53:10]

Description was changed from

==========
Move browsing data deletion prefs to components

BUG=620317
==========

to

==========
Move browsing data deletion prefs to components

Move the pref_names related to browsing data deletion from chrome/common/ to
components/browsing_data. They will be needed in the componentized counters.

BUG=620317
==========

[ioanap, 2016-07-12 12:53:10]

ioanap@google.com changed reviewers:
+ melandory@chromium.org, msramek@chromium.org

[ioanap, 2016-07-12 12:53:49]

Please have a look!

Thank you,
Ioana

[msramek, 2016-07-12 13:27:48]

LGTM

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
File components/browsing_data/pref_names.cc (right):

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
components/browsing_data/pref_names.cc:11: // Clear browsing data delete time
period
nit: deletion
nit: period after "period" :)

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
components/browsing_data/pref_names.cc:14: // Clear Browsing Data dialog
preferences.
The preference above is also a CBD dialog preference. How about: "Clear Browsing
Data dialog datatype preferences." ?

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
File components/browsing_data/pref_names.h (right):

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
components/browsing_data/pref_names.h:13: extern const char
kDeleteBrowsingHistory[];
nit: Please add an empty line the same way it is in pref_names.cc

[ioanap, 2016-07-12 14:19:19]

ioanap@google.com changed reviewers:
+ dbeam@chromium.org, mkwst@chromium.org, msw@chromium.org

[ioanap, 2016-07-12 14:19:20]

msw@chromium.org: Please review changes in 
browser_ui_prefs.cc

mkwst@chromium.org: Please review changes in 
chrome/browser/extensions/api/browsing_data/

dbeam@chromium.org: Please review changes in 
chrome/browser/ui/webui/

Thank you,
Ioana

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
File components/browsing_data/pref_names.cc (right):

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
components/browsing_data/pref_names.cc:11: // Clear browsing data delete time
period
On 2016/07/12 13:27:48, msramek wrote:
> nit: deletion
> nit: period after "period" :)

Done.

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
components/browsing_data/pref_names.cc:14: // Clear Browsing Data dialog
preferences.
On 2016/07/12 13:27:48, msramek wrote:
> The preference above is also a CBD dialog preference. How about: "Clear
Browsing
> Data dialog datatype preferences." ?

Done.

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
File components/browsing_data/pref_names.h (right):

https://codereview.chromium.org/2136373003/diff/20001/components/browsing_dat...
components/browsing_data/pref_names.h:13: extern const char
kDeleteBrowsingHistory[];
On 2016/07/12 13:27:48, msramek wrote:
> nit: Please add an empty line the same way it is in pref_names.cc

Done.

[Mike West, 2016-07-12 14:23:02]

c/b/extensions/api/browsing_data LGTM.

[msw, 2016-07-12 17:58:23]

browser_ui_prefs.cc lgtm

[Dan Beam, 2016-07-13 02:16:20]

lgtm

[ioanap, 2016-07-13 09:01:12]

The CQ bit was checked by ioanap@google.com

[ioanap, 2016-07-13 09:01:12]

The patchset sent to the CQ was uploaded after l-g-t-m from msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2136373003/#ps60001
(title: "Fixed comment")

[commit-bot: I haz the power, 2016-07-13 09:01:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 11:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 11:33:04]

Failed to apply the patch.

[commit-bot: I haz the power, 2016-07-13 11:33:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 11:33:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 11:33:36]

Description was changed from

==========
Move browsing data deletion prefs to components

Move the pref_names related to browsing data deletion from chrome/common/ to
components/browsing_data. They will be needed in the componentized counters.

BUG=620317
==========

to

==========
Move browsing data deletion prefs to components

Move the pref_names related to browsing data deletion from chrome/common/ to
components/browsing_data. They will be needed in the componentized counters.

BUG=620317

Committed: https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a
Cr-Commit-Position: refs/heads/master@{#405123}
==========

[commit-bot: I haz the power, 2016-07-13 11:33:37]

Patchset 4 (id:??) landed as
https://crrev.com/918aa6d29219129f5c7eb32ea8e222b13b2a922a
Cr-Commit-Position: refs/heads/master@{#405123}