Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: ui/android/window_android.cc

Issue 2136373002: Make WindowAndroid a ViewAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@view3
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« ui/android/view_android.cc ('K') | « ui/android/window_android.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/android/window_android.h" 5 #include "ui/android/window_android.h"
6 6
7 #include "base/android/context_utils.h" 7 #include "base/android/context_utils.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 18 matching lines...) Expand all
29 29
30 ScopedJavaLocalRef<jobject> WindowAndroid::GetJavaObject() { 30 ScopedJavaLocalRef<jobject> WindowAndroid::GetJavaObject() {
31 return base::android::ScopedJavaLocalRef<jobject>(java_window_); 31 return base::android::ScopedJavaLocalRef<jobject>(java_window_);
32 } 32 }
33 33
34 bool WindowAndroid::RegisterWindowAndroid(JNIEnv* env) { 34 bool WindowAndroid::RegisterWindowAndroid(JNIEnv* env) {
35 return RegisterNativesImpl(env); 35 return RegisterNativesImpl(env);
36 } 36 }
37 37
38 WindowAndroid::~WindowAndroid() { 38 WindowAndroid::~WindowAndroid() {
39 DCHECK(parent_ == nullptr) << "WindowAndroid must be a root view.";
39 DCHECK(!compositor_); 40 DCHECK(!compositor_);
40 } 41 }
41 42
42 WindowAndroid* WindowAndroid::createForTesting() { 43 WindowAndroid* WindowAndroid::createForTesting() {
43 JNIEnv* env = AttachCurrentThread(); 44 JNIEnv* env = AttachCurrentThread();
44 jobject context = base::android::GetApplicationContext(); 45 jobject context = base::android::GetApplicationContext();
45 return new WindowAndroid( 46 return new WindowAndroid(
46 env, Java_WindowAndroid_createForTesting(env, context).obj()); 47 env, Java_WindowAndroid_createForTesting(env, context).obj());
47 } 48 }
48 49
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 } 136 }
136 137
137 bool WindowAndroid::CanRequestPermission(const std::string& permission) { 138 bool WindowAndroid::CanRequestPermission(const std::string& permission) {
138 JNIEnv* env = AttachCurrentThread(); 139 JNIEnv* env = AttachCurrentThread();
139 return Java_WindowAndroid_canRequestPermission( 140 return Java_WindowAndroid_canRequestPermission(
140 env, 141 env,
141 GetJavaObject().obj(), 142 GetJavaObject().obj(),
142 base::android::ConvertUTF8ToJavaString(env, permission).obj()); 143 base::android::ConvertUTF8ToJavaString(env, permission).obj());
143 } 144 }
144 145
146 WindowAndroid* WindowAndroid::GetWindowAndroid() {
147 DCHECK(parent_ == nullptr);
148 return this;
149 }
150
145 // ---------------------------------------------------------------------------- 151 // ----------------------------------------------------------------------------
146 // Native JNI methods 152 // Native JNI methods
147 // ---------------------------------------------------------------------------- 153 // ----------------------------------------------------------------------------
148 154
149 jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) { 155 jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
150 WindowAndroid* window = new WindowAndroid(env, obj); 156 WindowAndroid* window = new WindowAndroid(env, obj);
151 return reinterpret_cast<intptr_t>(window); 157 return reinterpret_cast<intptr_t>(window);
152 } 158 }
153 159
154 } // namespace ui 160 } // namespace ui
OLDNEW
« ui/android/view_android.cc ('K') | « ui/android/window_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698