Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2136323003:
Clean up eased-keyframes-non-animatable.html test to match W3C (Closed)
|
Created:
4 years, 5 months ago by sashab Modified:
4 years, 5 months ago Reviewers:
alancutter (OOO until 2018) CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove eased-keyframes-non-animatable.html test
Removed eased-keyframes-non-animatable.html test since it is a duplicate
of animation-model/animation-types/discrete-animation.html. Part of web
animations test burndown.
BUG=623437
Committed: https://crrev.com/71712a3b5094ad75cfaac6b25067668eb5962402
Cr-Commit-Position: refs/heads/master@{#405390}
Patch Set 1 #Patch Set 2 : Oops fixed small thin #Patch Set 3 : Removed test #Patch Set 4 : Rebase #Messages
Total messages: 23 (10 generated)
sashab@chromium.org changed reviewers: + alancutter@chromium.org
I think this is already covered by animation-model/animation-types/discrete-animation.html, we can probable remove it as a dupe.
On 2016/07/12 at 03:22:58, alancutter wrote: > I think this is already covered by animation-model/animation-types/discrete-animation.html, we can probable remove it as a dupe. *probably
Description was changed from ========== Clean up eased-keyframes-non-animatable.html test to match W3C Clean up web-animations-api/eased-keyframes-non-animatable.html test to match W3C standards. Part of web animations test burndown. BUG=623437 ========== to ========== Remove eased-keyframes-non-animatable.html test Removed eased-keyframes-non-animatable.html test since it is a duplicate of animation-model/animation-types/discrete-animation.html. Part of web animations test burndown. BUG=623437 ==========
Description was changed from ========== Clean up eased-keyframes-non-animatable.html test to match W3C Clean up web-animations-api/eased-keyframes-non-animatable.html test to match W3C standards. Part of web animations test burndown. BUG=623437 ========== to ========== Remove eased-keyframes-non-animatable.html test Removed eased-keyframes-non-animatable.html test since it is a duplicate of animation-model/animation-types/discrete-animation.html. Part of web animations test burndown. BUG=623437 ==========
lgtm
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
On 2016/07/13 at 06:22:27, commit-bot wrote: > Try jobs failed on following builders: > win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...) Hey Sasha, I'm not sure what's going on with the win_clang bot here. Can you try rebasing?
The CQ bit was checked by sashab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alancutter@chromium.org Link to the patchset: https://codereview.chromium.org/2136323003/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove eased-keyframes-non-animatable.html test Removed eased-keyframes-non-animatable.html test since it is a duplicate of animation-model/animation-types/discrete-animation.html. Part of web animations test burndown. BUG=623437 ========== to ========== Remove eased-keyframes-non-animatable.html test Removed eased-keyframes-non-animatable.html test since it is a duplicate of animation-model/animation-types/discrete-animation.html. Part of web animations test burndown. BUG=623437 Committed: https://crrev.com/71712a3b5094ad75cfaac6b25067668eb5962402 Cr-Commit-Position: refs/heads/master@{#405390} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/71712a3b5094ad75cfaac6b25067668eb5962402 Cr-Commit-Position: refs/heads/master@{#405390} |
