Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2136323002:
Properly calculate the localBounds for elements with overflow clipped (Closed)
|
Created:
4 years, 5 months ago by ymalik Modified:
4 years, 5 months ago Reviewers:
skobes CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionProperly calculate the localBounds for elements with overflow clipped
Before this CL, we would pick elements that were not really in the viewport
(e.g they belonged to another scroller above the viewport that had overflow:scroll)
BUG=594878
Committed: https://crrev.com/33fd0cb9308cad33938bc6cb7b69b1300af26e8b
Cr-Commit-Position: refs/heads/master@{#405318}
Patch Set 1 #Patch Set 2 : nit #
Total comments: 2
Patch Set 3 : review nit #
Messages
Total messages: 29 (14 generated)
Description was changed from ========== Properly calculate the localBounds for elements with overflow clipped Before this CL, we would pick elements that were not really in the viewport (e.g they belonged to another scroller above the viewport that had overflow:scroll) BUG=594878 ========== to ========== Properly calculate the localBounds for elements with overflow clipped Before this CL, we would pick elements that were not really in the viewport (e.g they belonged to another scroller above the viewport that had overflow:scroll) BUG=594878 ==========
ymalik@chromium.org changed reviewers: + skobes@chromium.org
lgtm w/ nit https://codereview.chromium.org/2136323002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp (right): https://codereview.chromium.org/2136323002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp:158: // Test that we don't descend into elements that clip overflow content since we nit: it's not that we will never descend into them, rather that we ignore the clipped content when computing visibility.
https://codereview.chromium.org/2136323002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp (right): https://codereview.chromium.org/2136323002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp:158: // Test that we don't descend into elements that clip overflow content since we On 2016/07/11 21:25:03, skobes wrote: > nit: it's not that we will never descend into them, rather that we ignore the > clipped content when computing visibility. Done!
The CQ bit was checked by ymalik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org Link to the patchset: https://codereview.chromium.org/2136323002/#ps40001 (title: "review nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ymalik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ymalik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ymalik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by ymalik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Properly calculate the localBounds for elements with overflow clipped Before this CL, we would pick elements that were not really in the viewport (e.g they belonged to another scroller above the viewport that had overflow:scroll) BUG=594878 ========== to ========== Properly calculate the localBounds for elements with overflow clipped Before this CL, we would pick elements that were not really in the viewport (e.g they belonged to another scroller above the viewport that had overflow:scroll) BUG=594878 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Properly calculate the localBounds for elements with overflow clipped Before this CL, we would pick elements that were not really in the viewport (e.g they belonged to another scroller above the viewport that had overflow:scroll) BUG=594878 ========== to ========== Properly calculate the localBounds for elements with overflow clipped Before this CL, we would pick elements that were not really in the viewport (e.g they belonged to another scroller above the viewport that had overflow:scroll) BUG=594878 Committed: https://crrev.com/33fd0cb9308cad33938bc6cb7b69b1300af26e8b Cr-Commit-Position: refs/heads/master@{#405318} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/33fd0cb9308cad33938bc6cb7b69b1300af26e8b Cr-Commit-Position: refs/heads/master@{#405318} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
