Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2136303002: Fix bootstrap on windows (Closed)

Created:
4 years, 5 months ago by martiniss
Modified:
4 years, 5 months ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bootstrap on windows Also uses ROOT_DIR instead of hardcoding the value. R=dnj Committed: https://github.com/luci/recipes-py/commit/ce485a8a394dcc1561b5ecdd337a85002083de5b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M recipes.py View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
martiniss
PTAL Follow up from https://codereview.chromium.org/2136203002/
4 years, 5 months ago (2016-07-11 21:09:50 UTC) #1
dnj
lgtm w/ comment addressed https://codereview.chromium.org/2136303002/diff/1/recipes.py File recipes.py (right): https://codereview.chromium.org/2136303002/diff/1/recipes.py#newcode394 recipes.py:394: ROOT_DIR, 'ENV', 'bin', 'python'), Note ...
4 years, 5 months ago (2016-07-11 21:35:52 UTC) #2
martiniss
https://codereview.chromium.org/2136303002/diff/1/recipes.py File recipes.py (right): https://codereview.chromium.org/2136303002/diff/1/recipes.py#newcode394 recipes.py:394: ROOT_DIR, 'ENV', 'bin', 'python'), On 2016/07/11 at 21:35:52, dnj ...
4 years, 5 months ago (2016-07-11 23:45:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136303002/20001
4 years, 5 months ago (2016-07-11 23:45:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/recipes-py/commit/ce485a8a394dcc1561b5ecdd337a85002083de5b
4 years, 5 months ago (2016-07-11 23:47:57 UTC) #8
martiniss
4 years, 5 months ago (2016-07-12 00:41:35 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2139103002/ by martiniss@chromium.org.

The reason for reverting is: Appears to have broken the roller... :(.

Powered by Google App Engine
This is Rietveld 408576698