Enables per-function far-branches for ARM and MIPS.

runtime/vm/compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
 
 #include "vm/ast_printer.h"
 #include "vm/code_generator.h"
@@ skipping 470 matching lines @@
 
       // Perform register allocation on the SSA graph.
       FlowGraphAllocator allocator(*flow_graph);
       allocator.AllocateRegisters();
 
       if (FLAG_print_flow_graph || FLAG_print_flow_graph_optimized) {
         FlowGraphPrinter::PrintGraph("After Optimizations", flow_graph);
       }
     }
 
-    Assembler assembler;
-    FlowGraphCompiler graph_compiler(&assembler,
-                                     *flow_graph,
-                                     optimized);
-    {
-      TimerScope timer(FLAG_compiler_stats,
-                       &CompilerStats::graphcompiler_timer,
-                       isolate);
-      graph_compiler.CompileGraph();
-    }
-    {
-      TimerScope timer(FLAG_compiler_stats,
-                       &CompilerStats::codefinalizer_timer,
-                       isolate);
-      const Code& code = Code::Handle(
-          Code::FinalizeCode(function, &assembler, optimized));
-      code.set_is_optimized(optimized);
-      graph_compiler.FinalizePcDescriptors(code);
-      graph_compiler.FinalizeDeoptInfo(code);
-      graph_compiler.FinalizeStackmaps(code);
-      graph_compiler.FinalizeVarDescriptors(code);
-      graph_compiler.FinalizeExceptionHandlers(code);
-      graph_compiler.FinalizeComments(code);
-      graph_compiler.FinalizeStaticCallTargetsTable(code);
+    bool assembled = false;
+    while (!assembled) {
+      LongJump* assembler_old_base = isolate->long_jump_base();
+      LongJump assembler_jump;
+      isolate->set_long_jump_base(&assembler_jump);
+      if (setjmp(*bailout_jump.Set()) == 0) {
+        Assembler assembler(function.needs_far_branches());

[regis, 2013/07/31 18:01:12]

I think that the property of requiring far branches belongs to the flow graph,
rather than to the function. I can imagine that the unoptimized version of a
function does not require far branches, whereas the optimized one, with
inlining, does require it. The opposite could be true too, with the optimized
version being more compact.

[zra, 2013/07/31 20:10:52]

That makes sense to me. I've moved the flag to the FlowGraph.

+        FlowGraphCompiler graph_compiler(&assembler,
+                                         *flow_graph,
+                                         optimized);
+        {
+          TimerScope timer(FLAG_compiler_stats,
+                           &CompilerStats::graphcompiler_timer,
+                           isolate);
+          graph_compiler.CompileGraph();
+          assembled = true;
+        }
+        {
+          TimerScope timer(FLAG_compiler_stats,
+                           &CompilerStats::codefinalizer_timer,
+                           isolate);
+          const Code& code = Code::Handle(
+              Code::FinalizeCode(function, &assembler, optimized));
+          code.set_is_optimized(optimized);
+          graph_compiler.FinalizePcDescriptors(code);
+          graph_compiler.FinalizeDeoptInfo(code);
+          graph_compiler.FinalizeStackmaps(code);
+          graph_compiler.FinalizeVarDescriptors(code);
+          graph_compiler.FinalizeExceptionHandlers(code);
+          graph_compiler.FinalizeComments(code);
+          graph_compiler.FinalizeStaticCallTargetsTable(code);
 
-      if (optimized) {
-        if (osr_id == Isolate::kNoDeoptId) {
-          CodePatcher::PatchEntry(Code::Handle(function.CurrentCode()));
-          if (FLAG_trace_compiler) {
-            OS::Print("--> patching entry %#"Px"\n",
-                      Code::Handle(function.unoptimized_code()).EntryPoint());
+          if (optimized) {
+            if (osr_id == Isolate::kNoDeoptId) {
+              CodePatcher::PatchEntry(Code::Handle(function.CurrentCode()));
+              if (FLAG_trace_compiler) {
+                OS::Print("--> patching entry %#"Px"\n",
+                    Code::Handle(function.unoptimized_code()).EntryPoint());
+              }
+            }
+            function.SetCode(code);
+
+            for (intptr_t i = 0; i < guarded_fields.length(); i++) {
+              const Field& field = *guarded_fields[i];
+              field.RegisterDependentCode(code);
+            }
+          } else {
+            function.set_unoptimized_code(code);
+            function.SetCode(code);
+            ASSERT(CodePatcher::CodeIsPatchable(code));
           }
         }
-        function.SetCode(code);
+        is_compiled = true;
+      } else {
+        isolate->object_store()->clear_sticky_error();
 
-        for (intptr_t i = 0; i < guarded_fields.length(); i++) {
-          const Field& field = *guarded_fields[i];
-          field.RegisterDependentCode(code);
-        }
-      } else {
-        function.set_unoptimized_code(code);
-        function.SetCode(code);
-        ASSERT(CodePatcher::CodeIsPatchable(code));
+        ASSERT(!function.needs_far_branches());
+        function.set_needs_far_branches(true);
+        is_compiled = false;
       }
+      isolate->set_long_jump_base(assembler_old_base);
+      isolate->set_deopt_id(prev_deopt_id);
     }
-    is_compiled = true;
   } else {
     // We bailed out.
     Error& bailout_error = Error::Handle(
         isolate->object_store()->sticky_error());
     isolate->object_store()->clear_sticky_error();
     if (FLAG_trace_bailout) {
       OS::Print("%s\n", bailout_error.ToErrorCString());
     }
     // We only bail out from generating ssa code.
     ASSERT(optimized);
@@ skipping 334 matching lines @@
       Object::Handle(isolate->object_store()->sticky_error());
     isolate->object_store()->clear_sticky_error();
     isolate->set_long_jump_base(base);
     return result.raw();
   }
   UNREACHABLE();
   return Object::null();
 }
 
 }  // namespace dart