Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2136293002:
Flip remaining main Mac bots to GN. (Closed)
|
Created:
4 years, 5 months ago by Dirk Pranke Modified:
4 years, 5 months ago Reviewers:
Robert Sesek CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip remaining main Mac bots to GN.
This flips the remaining main Mac bots to GN, e.g.:
- chromium
- Mac
- chromium.chrome
- Google Mac
- chromium.perf
- Mac Builder
- official.desktop
- mac64
- official.desktop.continuous
- mac trunk
There are various FYI and memory builders still, plus the GYP
builder on the chromium.mac waterfall.
R=rsesek@chromium.org
NOTRY=true
BUG=618468
Committed: https://crrev.com/f7d150aa0ad0c54760d5593ac04afee50e1e5286
Cr-Commit-Position: refs/heads/master@{#404744}
Patch Set 1 #
Messages
Total messages: 16 (6 generated)
lgtm
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Flip remaining main Mac bots to GN. This flips the remaining main Mac bots to GN, e.g.: - chromium - Mac - chromium.chrome - Google Mac - chromium.perf - Mac Builder - official.desktop - mac64 - official.desktop.continuous - mac trunk There are various FYI and memory builders still, plus the GYP builder on the chromium.mac waterfall. R=rsesek@chromium.org BUG=618468 ========== to ========== Flip remaining main Mac bots to GN. This flips the remaining main Mac bots to GN, e.g.: - chromium - Mac - chromium.chrome - Google Mac - chromium.perf - Mac Builder - official.desktop - mac64 - official.desktop.continuous - mac trunk There are various FYI and memory builders still, plus the GYP builder on the chromium.mac waterfall. R=rsesek@chromium.org NOTRY=true BUG=618468 ==========
The win_chromium_rel_ng failures are unrelated to this CL, the linux_chromium_asan_rel_ng builder is still running but any failures will also be unrelated, and the linux_chromium_chromeos_rel_ng builder seems wedged, but it will also be unaffected by this CL. So, I'm going to skip the remaining try jobs and go ahead and land this.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Flip remaining main Mac bots to GN. This flips the remaining main Mac bots to GN, e.g.: - chromium - Mac - chromium.chrome - Google Mac - chromium.perf - Mac Builder - official.desktop - mac64 - official.desktop.continuous - mac trunk There are various FYI and memory builders still, plus the GYP builder on the chromium.mac waterfall. R=rsesek@chromium.org NOTRY=true BUG=618468 ========== to ========== Flip remaining main Mac bots to GN. This flips the remaining main Mac bots to GN, e.g.: - chromium - Mac - chromium.chrome - Google Mac - chromium.perf - Mac Builder - official.desktop - mac64 - official.desktop.continuous - mac trunk There are various FYI and memory builders still, plus the GYP builder on the chromium.mac waterfall. R=rsesek@chromium.org NOTRY=true BUG=618468 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Flip remaining main Mac bots to GN. This flips the remaining main Mac bots to GN, e.g.: - chromium - Mac - chromium.chrome - Google Mac - chromium.perf - Mac Builder - official.desktop - mac64 - official.desktop.continuous - mac trunk There are various FYI and memory builders still, plus the GYP builder on the chromium.mac waterfall. R=rsesek@chromium.org NOTRY=true BUG=618468 ========== to ========== Flip remaining main Mac bots to GN. This flips the remaining main Mac bots to GN, e.g.: - chromium - Mac - chromium.chrome - Google Mac - chromium.perf - Mac Builder - official.desktop - mac64 - official.desktop.continuous - mac trunk There are various FYI and memory builders still, plus the GYP builder on the chromium.mac waterfall. R=rsesek@chromium.org NOTRY=true BUG=618468 Committed: https://crrev.com/f7d150aa0ad0c54760d5593ac04afee50e1e5286 Cr-Commit-Position: refs/heads/master@{#404744} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f7d150aa0ad0c54760d5593ac04afee50e1e5286 Cr-Commit-Position: refs/heads/master@{#404744}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2138313002/ by dpranke@chromium.org. The reason for reverting is: "Mac" builder on /p/chromium fails follow-up ninja build claiming that things are dirty: https://build.chromium.org/p/chromium/builders/Mac/builds/17564/steps/compile... The official.desktop.continuous builder is breaking due to the missing remoting crashreporting link that I had thought I fixed but maybe forgot to land .... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
