[Remoting Android] Fix Painting After Rotation Bug

[Remoting Android] Fix Painting After Rotation Bug

Previous CL 2132883002 removed the attachRedrawCallback() call in
Desktop.onStart() since it will be called in DesktopView.surfaceChanged().
This introduces a bug that if requestRepaint() is called before
surfaceChanged(), then mRepaintPending will be set to true and
mDisplay.redrawGraphics() will do nothing. paint() will not be called since
the redraw callback is not set, and mRepaintPending will not be set back to
false, making it skip all future render requests until paint() is triggered
by JniVideoRenderer in C++.

This CL fixes this problem by moving attachRedrawCallback() to the ctor
of DesktopView. paint() already has checks to prevent rendering happens if
the DesktopView is not ready yet.

BUG=627191
Committed: https://crrev.com/856d9fb7b4fa883fc66ec27ec3901b3b3683875a
Cr-Commit-Position: refs/heads/master@{#404732}

[Yuwei, 2016-07-11 20:17:25]

Description was changed from

==========
[Remoting Android] Fix Painting After Rotation Bug

Previous CL 2132883002 removed the attachRedrawCallback() call in
Desktop.onStart() since it will be called in DesktopView.surfaceChanged().
This introduces a bug that if requestRepaint() is called before
surfaceChanged(), then mRepaintPending will be set to true and
mDisplay.redrawGraphics() will do nothing. paint() will not be called since
the redraw callback is not set, and mRepaintPending will not be set back to
false, making it skip all future render requests.

This CL fixes this problem by moving attachRedrawCallback() to the ctor
of DesktopView. paint() already has checks to prevent rendering happens if
the DesktopView is not ready yet.

BUG=627191
==========

to

==========
[Remoting Android] Fix Painting After Rotation Bug

Previous CL 2132883002 removed the attachRedrawCallback() call in
Desktop.onStart() since it will be called in DesktopView.surfaceChanged().
This introduces a bug that if requestRepaint() is called before
surfaceChanged(), then mRepaintPending will be set to true and
mDisplay.redrawGraphics() will do nothing. paint() will not be called since
the redraw callback is not set, and mRepaintPending will not be set back to
false, making it skip all future render requests until paint() is triggered
by JniVideoRenderer in C++.

This CL fixes this problem by moving attachRedrawCallback() to the ctor
of DesktopView. paint() already has checks to prevent rendering happens if
the DesktopView is not ready yet.

BUG=627191
==========

[Yuwei, 2016-07-11 20:21:42]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org

[Yuwei, 2016-07-11 20:21:42]

ptal

https://codereview.chromium.org/2136233002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/2136233002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:146:
mRepaintPending = false;
mRepaintPending would also be frozen if image == null (we haven't seen any
problem so far?). Moving `mRepaintPending = false` above it should fix this
problem.

[joedow, 2016-07-11 20:32:44]

lgtm

[Yuwei, 2016-07-11 20:33:47]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-07-11 20:34:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 21:21:13]

Description was changed from

==========
[Remoting Android] Fix Painting After Rotation Bug

Previous CL 2132883002 removed the attachRedrawCallback() call in
Desktop.onStart() since it will be called in DesktopView.surfaceChanged().
This introduces a bug that if requestRepaint() is called before
surfaceChanged(), then mRepaintPending will be set to true and
mDisplay.redrawGraphics() will do nothing. paint() will not be called since
the redraw callback is not set, and mRepaintPending will not be set back to
false, making it skip all future render requests until paint() is triggered
by JniVideoRenderer in C++.

This CL fixes this problem by moving attachRedrawCallback() to the ctor
of DesktopView. paint() already has checks to prevent rendering happens if
the DesktopView is not ready yet.

BUG=627191
==========

to

==========
[Remoting Android] Fix Painting After Rotation Bug

Previous CL 2132883002 removed the attachRedrawCallback() call in
Desktop.onStart() since it will be called in DesktopView.surfaceChanged().
This introduces a bug that if requestRepaint() is called before
surfaceChanged(), then mRepaintPending will be set to true and
mDisplay.redrawGraphics() will do nothing. paint() will not be called since
the redraw callback is not set, and mRepaintPending will not be set back to
false, making it skip all future render requests until paint() is triggered
by JniVideoRenderer in C++.

This CL fixes this problem by moving attachRedrawCallback() to the ctor
of DesktopView. paint() already has checks to prevent rendering happens if
the DesktopView is not ready yet.

BUG=627191
==========

[commit-bot: I haz the power, 2016-07-11 21:21:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-11 21:24:07]

Description was changed from

==========
[Remoting Android] Fix Painting After Rotation Bug

Previous CL 2132883002 removed the attachRedrawCallback() call in
Desktop.onStart() since it will be called in DesktopView.surfaceChanged().
This introduces a bug that if requestRepaint() is called before
surfaceChanged(), then mRepaintPending will be set to true and
mDisplay.redrawGraphics() will do nothing. paint() will not be called since
the redraw callback is not set, and mRepaintPending will not be set back to
false, making it skip all future render requests until paint() is triggered
by JniVideoRenderer in C++.

This CL fixes this problem by moving attachRedrawCallback() to the ctor
of DesktopView. paint() already has checks to prevent rendering happens if
the DesktopView is not ready yet.

BUG=627191
==========

to

==========
[Remoting Android] Fix Painting After Rotation Bug

Previous CL 2132883002 removed the attachRedrawCallback() call in
Desktop.onStart() since it will be called in DesktopView.surfaceChanged().
This introduces a bug that if requestRepaint() is called before
surfaceChanged(), then mRepaintPending will be set to true and
mDisplay.redrawGraphics() will do nothing. paint() will not be called since
the redraw callback is not set, and mRepaintPending will not be set back to
false, making it skip all future render requests until paint() is triggered
by JniVideoRenderer in C++.

This CL fixes this problem by moving attachRedrawCallback() to the ctor
of DesktopView. paint() already has checks to prevent rendering happens if
the DesktopView is not ready yet.

BUG=627191

Committed: https://crrev.com/856d9fb7b4fa883fc66ec27ec3901b3b3683875a
Cr-Commit-Position: refs/heads/master@{#404732}
==========

[commit-bot: I haz the power, 2016-07-11 21:24:08]

Patchset 1 (id:??) landed as
https://crrev.com/856d9fb7b4fa883fc66ec27ec3901b3b3683875a
Cr-Commit-Position: refs/heads/master@{#404732}