Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 213623004: Partial revert of CL 190633002. JS wrapper for GAIA iframe focus grab is back (Closed)

Created:
6 years, 8 months ago by merkulova
Modified:
6 years, 8 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Partial revert of CL 190633002. JS wrapper for GAIA iframe focus grab is back BUG=359510 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261426

Patch Set 1 #

Total comments: 1

Patch Set 2 : Code block moved. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 5 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
merkulova
6 years, 8 months ago (2014-04-03 11:08:05 UTC) #1
Nikita (slow)
>> Js hack for gaia frame is back. To be more specific: "JS wrapper for ...
6 years, 8 months ago (2014-04-03 11:14:45 UTC) #2
ygorshenin1
lgtm
6 years, 8 months ago (2014-04-03 11:19:23 UTC) #3
Nikita (slow)
https://codereview.chromium.org/213623004/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right): https://codereview.chromium.org/213623004/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#newcode1371 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1371: policy::BrowserPolicyConnectorChromeOS* connector = You don't need this code move, ...
6 years, 8 months ago (2014-04-03 11:46:11 UTC) #4
merkulova
Moved back.
6 years, 8 months ago (2014-04-03 11:52:36 UTC) #5
Nikita (slow)
lgtm Does this fixes the original issue?
6 years, 8 months ago (2014-04-03 12:08:56 UTC) #6
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 8 months ago (2014-04-03 12:15:23 UTC) #7
merkulova
The CQ bit was unchecked by merkulova@chromium.org
6 years, 8 months ago (2014-04-03 12:15:27 UTC) #8
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 8 months ago (2014-04-03 13:04:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/213623004/20001
6 years, 8 months ago (2014-04-03 13:04:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 15:48:20 UTC) #11
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 15:48:21 UTC) #12
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 8 months ago (2014-04-03 15:49:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/213623004/20001
6 years, 8 months ago (2014-04-03 15:50:17 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:56:54 UTC) #15
Message was sent while issue was closed. 
Change committed as 261426

Powered by Google App Engine
This is Rietveld 408576698