Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 2136223004: Don't insert additional ':' when changing a named argument name. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't insert additional ':' when changing a named argument name. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7d9d451730f858202e56183c66f228773b7e8188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 2 chunks +25 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-12 22:52:01 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-12 23:06:44 UTC) #2
scheglov
4 years, 5 months ago (2016-07-13 00:26:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d9d451730f858202e56183c66f228773b7e8188 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698