Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2136223003: ResourceDispatcherHostDelegate::OnResponseStarted doesn't need IPC::Sender (Closed)

Created:
4 years, 5 months ago by yhirano
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, loading-reviews_chromium.org, mmenke, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ResourceDispatcherHostDelegate::OnResponseStarted doesn't need IPC::Sender As it is not used, this CL removes the parameter from the interface. BUG=None Committed: https://crrev.com/561a0b2acdb1042af6eb89ba9657d51cc65bddef Cr-Commit-Position: refs/heads/master@{#404959}

Patch Set 1 #

Patch Set 2 : fix #

Messages

Total messages: 12 (5 generated)
yhirano
+jochen@ for content/ and chrome/. +torne@ for android_webview/.
4 years, 5 months ago (2016-07-12 06:24:47 UTC) #3
Torne
android_webview LGTM
4 years, 5 months ago (2016-07-12 12:29:20 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-12 15:34:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136223003/20001
4 years, 5 months ago (2016-07-13 01:44:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 03:27:10 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:27:52 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:30:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/561a0b2acdb1042af6eb89ba9657d51cc65bddef
Cr-Commit-Position: refs/heads/master@{#404959}

Powered by Google App Engine
This is Rietveld 408576698