Fix bootstrap cwd

Fix bootstrap cwd

The cwd of the subprocess (when bootstrapping) was set to the location of the
recipe engine. This caused anything which referenced a package with the
--package arg to refer to the recipe engine package.

TBR=iannucci

Committed: https://github.com/luci/recipes-py/commit/0a6ab680699355151bf3387074f4656c48698d72

[martiniss, 2016-07-11 20:09:26]

martiniss@chromium.org changed reviewers:
+ dnj@chromium.org, iannucci@chromium.org, phajdan.jr@chromium.org

[martiniss, 2016-07-11 20:09:27]

PTAL

Fixes a semi critical bug in the autoroller.

[martiniss, 2016-07-11 20:45:33]

Description was changed from

==========
Fix bootstrap cwd

The cwd of the subprocess (when bootstrapping) was set to the location of the
recipe engine. This caused anything which referenced a package with the
--package arg to refer to the recipe engine package.
==========

to

==========
Fix bootstrap cwd

The cwd of the subprocess (when bootstrapping) was set to the location of the
recipe engine. This caused anything which referenced a package with the
--package arg to refer to the recipe engine package.

TBR=iannucci
==========

[martiniss, 2016-07-11 20:46:06]

TBR because fairly urgent to land; all reviewers are either asleep or at gopher
con

[martiniss, 2016-07-11 20:46:07]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-07-11 20:46:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 20:48:15]

Description was changed from

==========
Fix bootstrap cwd

The cwd of the subprocess (when bootstrapping) was set to the location of the
recipe engine. This caused anything which referenced a package with the
--package arg to refer to the recipe engine package.

TBR=iannucci
==========

to

==========
Fix bootstrap cwd

The cwd of the subprocess (when bootstrapping) was set to the location of the
recipe engine. This caused anything which referenced a package with the
--package arg to refer to the recipe engine package.

TBR=iannucci

Committed:
https://github.com/luci/recipes-py/commit/0a6ab680699355151bf3387074f4656c486...
==========

[commit-bot: I haz the power, 2016-07-11 20:48:16]

Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/0a6ab680699355151bf3387074f4656c486...

[dnj (Google), 2016-07-11 20:57:05]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2016-07-11 20:57:06]

lgtm, few comments

https://codereview.chromium.org/2136203002/diff/1/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2136203002/diff/1/recipes.py#newcode396
recipes.py:396: os.path.join(ROOT_DIR, 'recipes.py')] + original_sys_argv[1:])
We already have this value as ROOT_DIR, don't we?

https://codereview.chromium.org/2136203002/diff/1/recipes.py#newcode396
recipes.py:396: os.path.join(ROOT_DIR, 'recipes.py')] + original_sys_argv[1:])
Are all these forward slashes Windows-compatible? Seems like we should be using
"os.path.join"?