Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2136163002: [Cronet] Remove buffer.compact from CronetChunkedOutputStream (Closed)

Created:
4 years, 5 months ago by xunjieli
Modified:
4 years, 5 months ago
Reviewers:
kapishnikov, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Cronet] Remove buffer.compact from CronetChunkedOutputStream This CL unifies the buffer manipulation code in CronetChunkedOutputStream to match the one in CronetFixedOutputStream. BUG=626653 TBR=kapishnikov@chromium.org TBR=mef@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2133273002 Cr-Commit-Position: refs/heads/master@{#404664} (cherry picked from commit bf9178a723b6fb899d7b73f2793d532fc4badd66)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -37 lines) Patch
M components/cronet/android/java/src/org/chromium/net/urlconnection/CronetChunkedOutputStream.java View 5 chunks +40 lines, -37 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetChunkedOutputStreamTest.java View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
xunjieli
This is to merge the change into M53. I will CQ it once I confirmed ...
4 years, 5 months ago (2016-07-11 18:50:40 UTC) #1
xunjieli
On 2016/07/11 18:50:40, xunjieli wrote: > This is to merge the change into M53. I ...
4 years, 5 months ago (2016-07-11 19:20:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136163002/1
4 years, 5 months ago (2016-07-11 19:20:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 19:21:13 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 19:21:26 UTC) #6
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698