Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2136143002: Stop reading svn buildspec (Closed)

Created:
4 years, 5 months ago by dimu
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop reading svn buildspec BUG= R=mmoss, robertocn

Patch Set 1 #

Total comments: 2

Patch Set 2 : Stop reading svn buildspec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M tools/bisect-builds.py View 1 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dimu
4 years, 5 months ago (2016-07-11 18:20:41 UTC) #1
dimu1
On 2016/07/11 18:20:41, dimu wrote:
4 years, 5 months ago (2016-07-11 18:21:50 UTC) #4
Michael Moss
lgtm https://codereview.chromium.org/2136143002/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/2136143002/diff/1/tools/bisect-builds.py#newcode30 tools/bisect-builds.py:30: DEPS_FILE_NEW = ('https://chromium.googlesource.com/chromium/src/+/%s/DEPS') Maybe just call it DEPS_FILE ...
4 years, 5 months ago (2016-07-11 18:32:25 UTC) #6
RobertoCN
4 years, 5 months ago (2016-07-15 23:05:50 UTC) #7 
This looks good. Although I'd prefer if we refer to the old SVN Revisions as
commit positions (which is what they are now)

Powered by Google App Engine
This is Rietveld 408576698