Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 213613002: Change the BMP decoder to not reject paletted images which use color indexes (Closed)

Created:
6 years, 9 months ago by Peter Kasting
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Change the BMP decoder to not reject paletted images which use color indexes beyond the end of the color table. Instead, draw these pixels as black. This matches Firefox and IE. BUG=176678 TEST=none R=abarth@chromium.org, hclam@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170193

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M Source/platform/image-decoders/bmp/BMPImageReader.h View 1 chunk +0 lines, -1 line 1 comment Download
M Source/platform/image-decoders/bmp/BMPImageReader.cpp View 4 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Peter Kasting
https://codereview.chromium.org/213613002/diff/1/Source/platform/image-decoders/bmp/BMPImageReader.h File Source/platform/image-decoders/bmp/BMPImageReader.h (left): https://codereview.chromium.org/213613002/diff/1/Source/platform/image-decoders/bmp/BMPImageReader.h#oldcode335 Source/platform/image-decoders/bmp/BMPImageReader.h:335: size_t m_tableSizeInBytes; This is just cleanup unconnected to the ...
6 years, 9 months ago (2014-03-26 21:35:52 UTC) #1
Alpha Left Google
lgtm
6 years, 9 months ago (2014-03-26 21:41:38 UTC) #2
Peter Kasting
Apparently only the trunk/ OWNERS can approve changes in this dir... that seems suboptimal. +abarth ...
6 years, 9 months ago (2014-03-26 21:46:35 UTC) #3
abarth-chromium
rslgtm
6 years, 9 months ago (2014-03-27 03:39:43 UTC) #4
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-27 03:40:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/213613002/1
6 years, 9 months ago (2014-03-27 03:40:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 03:45:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-27 03:45:47 UTC) #8
Peter Kasting
6 years, 9 months ago (2014-03-27 18:38:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r170193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698