Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2136113002: Rename DOMVisualViewport to VisualViewport in Window.idl (Closed)

Created:
4 years, 5 months ago by ymalik
Modified:
4 years, 5 months ago
Reviewers:
bokan, bashi
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DOMVisualViewport to VisualViewport in Window.idl BUG=595826 Committed: https://crrev.com/fa9981935add4f5b027b7b5188ba3204cae9dd94 Cr-Commit-Position: refs/heads/master@{#404777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
ymalik
4 years, 5 months ago (2016-07-11 17:15:36 UTC) #5
bokan
Sending to bashi@ for review.
4 years, 5 months ago (2016-07-11 17:28:37 UTC) #7
bashi
non-owner lgtm. Thanks for the fix!
4 years, 5 months ago (2016-07-11 22:40:45 UTC) #10
bokan
rs-lgtm
4 years, 5 months ago (2016-07-11 22:41:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136113002/1
4 years, 5 months ago (2016-07-11 22:42:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253432)
4 years, 5 months ago (2016-07-12 01:24:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136113002/1
4 years, 5 months ago (2016-07-12 02:47:37 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 04:05:25 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 04:05:39 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 04:06:34 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa9981935add4f5b027b7b5188ba3204cae9dd94
Cr-Commit-Position: refs/heads/master@{#404777}

Powered by Google App Engine
This is Rietveld 408576698