Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2136103011: Replace switch statements in instanced vertex shaders (Closed)

Created:
4 years, 5 months ago by csmartdalton
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Replace switch statements in instanced vertex shaders Replaces switch statements with 3-way if’s. The switches as they were seemed to be the cause of an Adreno compiler crash. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2136103011 Committed: https://skia.googlesource.com/skia/+/0caee1778d92c30ff6eb053f7fb58509d275a2df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -57 lines) Patch
M src/gpu/instanced/InstanceProcessor.cpp View 14 chunks +81 lines, -57 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 5 months ago (2016-07-13 04:35:13 UTC) #3
bsalomon
lgtm
4 years, 5 months ago (2016-07-13 14:26:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136103011/1
4 years, 5 months ago (2016-07-13 15:28:31 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 15:48:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0caee1778d92c30ff6eb053f7fb58509d275a2df

Powered by Google App Engine
This is Rietveld 408576698