Add StreamTextureWrapper/StreamTextureWrapperImpl

media/blink/surface_texture_frame_provider.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef _MEDIA_BLINK_SURFACE_TEXTURE_FRAME_PROVIDER_H_
+#define _MEDIA_BLINK_SURFACE_TEXTURE_FRAME_PROVIDER_H_
+
+#include "cc/layers/video_frame_provider.h"
+#include "media/blink/media_blink_export.h"
+
+namespace media {
+class VideoFrame;
+
+// Interface defining a VideoFrameProvider that is backed by an underlying
+// Android SurfaceTexture.
+class SurfaceTextureFrameProvider : public cc::VideoFrameProvider {

[liberato (no reviews please), 2016/07/13 16:42:50]

not sure if the additional abstraction is needed -- it's already a
VideoFrameProvider.  is something going to know that it has a
SurfaceTextureFrameProvider that isn't also going to know about
SurfaceTextureFrameProviderImpl?

the reason i ask is that STFP is already a VFP, which is pretty abstract.  maybe
this would be better as a separate interface that has just
GetSurfaceTextureIdentifier() and UpdateTextureSize(). 
SurfaceTextureFrameProviderImpl could inherit from that too.  avoids requiring
the consumer to understand cc/layers/VFP.

it depends a lot on how you're planning to do setup / tear down of all of this.

[tguilbert, 2016/07/14 02:47:03]

I can show you the overall setup/tear down of this in the prototype that I have.
This is going to be used instead of |compositor_| in WMPI, when creating the
|video_weblayer_|.

The main reason I created this abstraction was because the STFP_impl needs a
StreamTextureFactory, which is in the content directory.

From what I understand, I could not have the SFTP_impl live in the media folder
since it couldn't include the StreamTextureFactory.

Is there a better way to organize which file lives where?

[liberato (no reviews please), 2016/07/14 16:41:30]

hrm, not sure.  i forgot that StreamTextureFactory is in content/, which is
really annoying.

STF should probably be in media, to be honest.  not sure how big of a move that
is, or if it's worth it.

+ public:
+  SurfaceTextureFrameProvider() {}
+  virtual ~SurfaceTextureFrameProvider() {}
+
+  // Initialize and start providing frames if possible.
+  // The provided |task_runner| will be used to "signal" new frames (and most
+  // likely should be the compositor's TaskRunner).
+  virtual void Initialize(
+      scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+      const gfx::Size& natural_size) = 0;
+
+  // TODO(tguilbert): Define and document return value on failure. To be
+  // submitted as part of crbug.com/627658.
+  virtual int GetSurfaceTextureIdentifier() = 0;

[liberato (no reviews please), 2016/07/13 16:42:50]

is this to tell the browser how to find the Surface for MP?

maybe just leave it out altogether since it isn't called, isn't documented, and
isn't implemented.  :)

[tguilbert, 2016/07/14 02:47:02]

That is the plan :) I am using some hard coded values in my prototype, but you
are right... No need in adding it here just yet then.

+
+  // Should be called whenever the Video's natural size changes.
+  virtual void UpdateTextureSize(const gfx::Size& natural_size) = 0;
+};
+
+}  // namespace media
+
+#endif  // _MEDIA_BLINK_SURFACE_TEXTURE_FRAME_PROVIDER_H_