Makes 'Disconnect Account' overlay in chrome://settings accessible thru a URL

chrome/browser/resources/options/manage_profile_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
@@ skipping 577 matching lines @@
       loadTimeData.overrideValues(replacements);
       $('manage-profile-overlay-create').hidden = true;
       $('manage-profile-overlay-manage').hidden = true;
       $('manage-profile-overlay-delete').hidden = true;
       $('disconnect-managed-profile-domain-information').innerHTML =
           loadTimeData.getString('disconnectManagedProfileDomainInformation');
       $('disconnect-managed-profile-text').innerHTML =
           loadTimeData.getString('disconnectManagedProfileText');
       $('manage-profile-overlay-disconnect-managed').hidden = false;
 
-      // Because this dialog isn't useful when refreshing or as part of the
-      // history, don't create a history entry for it when showing.
-      PageManager.showPageByName('manageProfile', false);
+      PageManager.showPageByName('signOut');
     },
 
     /**
      * Display the "Create Profile" dialog.
      * @private
      */
     showCreateDialog_: function() {
       PageManager.showPageByName('createProfile');
     },
   };
 
   // Forward public APIs to private implementations.
   cr.makePublic(ManageProfileOverlay, [
     'receiveDefaultProfileIconsAndNames',
     'receiveNewProfileDefaults',
     'receiveExistingProfileNames',
     'receiveHasProfileShortcuts',
     'setProfileInfo',
     'setProfileName',
     'showManageDialog',
     'showDeleteDialog',
     'showDisconnectManagedProfileDialog',
     'showCreateDialog',
   ]);
 

[Dan Beam, 2016/07/14 00:28:36]

/**
 * @extends {ManageProfileOverlay}
 * @constructor
 */

[Moe, 2016/07/14 15:08:47]

Done.

+  function DisconnectAccountOverlay() {
+    Page.call(this, 'signOut',
+              loadTimeData.getString('disconnectAccountTabTitle'),
+              'manage-profile-overlay');

[Dan Beam, 2016/07/14 00:28:36]

why are you using this name?  shouldn't it be disconnect-account-overlay?

[Moe, 2016/07/14 15:08:47]

the third argument is the ID of the div which is the overlay. I'm not adding any
new html. '#manage-profile-overlay' contains different sections for managing,
creating, deleting, and disconnecting enterprise profiles with only one being
visible at a time. 

+  };

[Dan Beam, 2016/07/14 00:28:36]

}; -> }

[Moe, 2016/07/14 15:08:47]

Done.

+
+  cr.addSingletonGetter(DisconnectAccountOverlay);
+
+  DisconnectAccountOverlay.prototype = {
+    // Inherit from ManageProfileOverlay.

[Dan Beam, 2016/07/14 00:28:36]

remove this comment

[Moe, 2016/07/14 15:08:47]

Done.

+    __proto__: ManageProfileOverlay.prototype,
+
+    /** @override */
+    canShowPage: function() {
+      var syncData = loadTimeData.getValue('syncData');
+      return syncData.signedIn && !syncData.signoutAllowed;
+    },
+
+    /** @override */
+    didShowPage: function() {
+      chrome.send('showDisconnectManagedProfileDialog');
+    }
+  };
+
   function CreateProfileOverlay() {
     Page.call(this, 'createProfile',
               loadTimeData.getString('createProfileTabTitle'),
               'manage-profile-overlay');
   };
 
   cr.addSingletonGetter(CreateProfileOverlay);
 
   CreateProfileOverlay.prototype = {
     // Inherit from ManageProfileOverlay.
@@ skipping 240 matching lines @@
     'onSuccess',
     'onWarning',
     'updateCreateInProgress',
     'updateSignedInStatus',
     'updateSupervisedUsersAllowed',
   ]);
 
   // Export
   return {
     ManageProfileOverlay: ManageProfileOverlay,
+    DisconnectAccountOverlay: DisconnectAccountOverlay,
     CreateProfileOverlay: CreateProfileOverlay,
   };
 });