Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2136083002:
Compare account name values, not addresses. (Closed)
|
Created:
4 years, 5 months ago by PEConn Modified:
4 years, 5 months ago Reviewers:
Bernhard Bauer CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCompare account name values, not addresses.
I fell prey to one of the classic Java bugs.
BUG=626544
Committed: https://crrev.com/cc204bc401676b28832554a79c2db8e7510eecfa
Cr-Commit-Position: refs/heads/master@{#405175}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use String.equals instead of TextUtils. #Patch Set 3 : Readded empty check. #Messages
Total messages: 33 (20 generated)
Patchset #1 (id:1) has been deleted
peconn@chromium.org changed reviewers: + bauerb@chromium.org
PTAL at this embarrassing fix.
The CQ bit was checked by peconn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM I hope you didn't get involved in a land war in asia... https://codereview.chromium.org/2136083002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java (right): https://codereview.chromium.org/2136083002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java:114: || TextUtils.equals(mOldAccountName, mNewAccountName)) { Do we know whether any of these can be null? If not, I would use String.equals() instead.
https://codereview.chromium.org/2136083002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java (right): https://codereview.chromium.org/2136083002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java:114: || TextUtils.equals(mOldAccountName, mNewAccountName)) { On 2016/07/12 08:33:58, Bernhard Bauer wrote: > Do we know whether any of these can be null? If not, I would use String.equals() > instead. mNewAccountName definitely shouldn't be (I added an assert to make that explicit). I prefer the symmetry of TextUtils.equal(str1, str2) to str1.equals(str2), but I'm happy to change it.
The CQ bit was checked by peconn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by peconn@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org Link to the patchset: https://codereview.chromium.org/2136083002/#ps40001 (title: "Use String.equals instead of TextUtils.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by peconn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by peconn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by peconn@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org Link to the patchset: https://codereview.chromium.org/2136083002/#ps60001 (title: "Readded null check.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Compare account name values, not addresses. I fell prey to one of the classic Java bugs. BUG=626544 ========== to ========== Compare account name values, not addresses. I fell prey to one of the classic Java bugs. BUG=626544 Committed: https://crrev.com/cc204bc401676b28832554a79c2db8e7510eecfa Cr-Commit-Position: refs/heads/master@{#405175} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/cc204bc401676b28832554a79c2db8e7510eecfa Cr-Commit-Position: refs/heads/master@{#405175} |
