Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2136073002: Change deprecation msg that webkitImageSmoothingEnabled will be removed in M55 (Closed)

Created:
4 years, 5 months ago by xlai (Olivia)
Modified:
4 years, 5 months ago
Reviewers:
Justin Novosad, foolip
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change deprecation msg that webkitImageSmoothingEnabled will be removed in M55 BUG=277199 Committed: https://crrev.com/90a2944268d8fde3c28a5dff081d9090339cf8bc Cr-Commit-Position: refs/heads/master@{#405155}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change after chromestatus entry is added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
xlai (Olivia)
As foolip@'s suggestion in blink-dev, it looks a good idea to tell users about removal ...
4 years, 5 months ago (2016-07-11 16:00:40 UTC) #2
Justin Novosad
On 2016/07/11 16:00:40, xlai (Olivia) wrote: > As foolip@'s suggestion in blink-dev, it looks a ...
4 years, 5 months ago (2016-07-11 18:01:56 UTC) #3
foolip
lgtm https://codereview.chromium.org/2136073002/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2136073002/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode58 third_party/WebKit/Source/core/frame/Deprecation.cpp:58: String replacedWillBeRemovedWithoutDetails(const char* feature, const char* replacement, int ...
4 years, 5 months ago (2016-07-12 10:36:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136073002/20001
4 years, 5 months ago (2016-07-12 15:52:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242653) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 17:24:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136073002/20001
4 years, 5 months ago (2016-07-13 14:03:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 15:15:11 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 15:15:23 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 15:17:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90a2944268d8fde3c28a5dff081d9090339cf8bc
Cr-Commit-Position: refs/heads/master@{#405155}

Powered by Google App Engine
This is Rietveld 408576698