Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2136043002: cc serialization perf test: Initialize with valid ID (Closed)

Created:
4 years, 5 months ago by Fady Samuel
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc serialization perf test: Initialize with valid ID cc_serialization_perftest.cc was failing a DCHECK due to an invalid RenderPass ID. This CL gives the RenderPass a valid ID to avoid the DCHECK. BUG=624459 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f43da76d4c063bf90c3a48a996d45e8bbbf8f94a Cr-Commit-Position: refs/heads/master@{#404682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M cc/ipc/cc_serialization_perftest.cc View 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Fady Samuel
4 years, 5 months ago (2016-07-11 15:03:42 UTC) #3
piman
lgtm
4 years, 5 months ago (2016-07-11 16:00:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136043002/1
4 years, 5 months ago (2016-07-11 16:37:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 17:20:01 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 17:20:05 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 17:21:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f43da76d4c063bf90c3a48a996d45e8bbbf8f94a
Cr-Commit-Position: refs/heads/master@{#404682}

Powered by Google App Engine
This is Rietveld 408576698