Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2136003003: Put background filters on the makeWithFilter() fast-path

Created:
4 years, 5 months ago by Anton Obzhirov
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put background filters on the makeWithFilter() fast-path Implements GLRenderer::ApplyBackgroundFilters using ApplyImageFilter API. BUG=613233 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -55 lines) Patch
M cc/output/gl_renderer.h View 1 chunk +4 lines, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +30 lines, -54 lines 2 comments Download

Messages

Total messages: 10 (7 generated)
Anton Obzhirov
On 2016/07/12 10:23:23, Anton Obzhirov wrote: > mailto:a.obzhirov@samsung.com changed reviewers: > + mailto:senorblanco@google.com Hi, this ...
4 years, 5 months ago (2016-07-12 10:28:00 UTC) #4
Stephen White
https://codereview.chromium.org/2136003003/diff/1/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc (right): https://codereview.chromium.org/2136003003/diff/1/cc/output/gl_renderer.cc#newcode1327 cc/output/gl_renderer.cc:1327: background_texture_size.set_height(background_image->height()); It looks like the backdrop_rect is also used ...
4 years, 5 months ago (2016-07-12 16:37:52 UTC) #6
Anton Obzhirov
4 years, 5 months ago (2016-07-14 12:32:09 UTC) #10
https://codereview.chromium.org/2136003003/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2136003003/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:1327:
background_texture_size.set_height(background_image->height());
On 2016/07/12 16:37:52, Stephen White wrote:
> It looks like the backdrop_rect is also used when doing shader-based blending,
> and setting an empty backdrop_rect may cause problems for that case.
> 
> Perhaps we should simply modify background_rect just below the call to
> ApplyBackgroundFilters() above to reflect the background filters case, and
leave
> it unmodified otherwise, so that shader-based blending continues to work.
> 
> We should also test the combination of the two. I'm actually not certain what
> the correct background_rect is in that case; I suppose it depends on the order
> of operations.
Yes, you are right, I'll move it up as you suggested. I also couldn't find a
test with blending and background filter, may be new one should be added.

Powered by Google App Engine
This is Rietveld 408576698