third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html - Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/crash-inserting-span.html

Issue 2135993003: Add null check to fix crash in blink::ComputedStyle::display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use of assert_selection Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../assert_selection.js"></script>

	5 <div id="log"></div>

	6 <script>

	7 // This test case was added to reproduce the crash reported by ClusterFuzz.
	yosin_UTC9 2016/07/14 01:08:52 We don't need to have this comment, we can use git We don't need to have this comment, we can use git log to know what this test is. joone 2016/07/14 07:06:54 Done. Show quoted text On 2016/07/14 01:08:52, Yosi_UTC9 wrote: > We don't need to have this comment, we can use git log to know what this test > is. Done.
	8 // See http://crbug.com/626991

	9 test(() => {

	10 assert_selection(

	11 '<span><p>^test</p><p>foo<span>bar</span>foo<span>bar</span>.\|</p></span >',

	12 selection => {

	13 selection.document.designMode = 'on';
	yosin_UTC9 2016/07/14 01:08:52 Please enclose a sample with '<div contenteditable Please enclose a sample with '<div contenteditable>' to avoid to use "document.designMode='on'" joone 2016/07/14 07:06:54 Done. Show quoted text On 2016/07/14 01:08:52, Yosi_UTC9 wrote: > Please enclose a sample with '<div contenteditable>' to avoid to use > "document.designMode='on'" Done.
	14 selection.document.execCommand('CreateLink', false, 'foo');
	yosin_UTC9 2016/07/14 01:08:52 Could you encode result of "createLink" command in Could you encode result of "createLink" command in sample input and expected result? joone 2016/07/14 07:06:54 Done. Show quoted text On 2016/07/14 01:08:52, Yosi_UTC9 wrote: > Could you encode result of "createLink" command in sample input and expected > result? Done. yosin_UTC9 2016/07/14 07:53:34 PS#5 still has "createLink", did you forget to upd Show quoted text On 2016/07/14 at 07:06:54, joone wrote: > On 2016/07/14 01:08:52, Yosi_UTC9 wrote: > > Could you encode result of "createLink" command in sample input and expected > > result? > > Done. PS#5 still has "createLink", did you forget to update this?
	15 selection.document.execCommand('inserthtml', false, '<span style="colo r:green">green</span>');

	16 },

	17 '<span><p><a href="foo"><span style="color:green">green\|</span></a></p>< /span>');

	18 }, 'Replace the selected tags with span tags');

	19 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('J')