Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2527)

Unified Diff: include/v8.h

Issue 2135973002: Adding V8_WARN_UNUSED_RESULT for specified TODOs (Closed) Base URL: git@github.com:danbev/v8.git@master
Patch Set: Using CHECK for Maybe<bool> results Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/wasm/wasm-js.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 2f3c77600745b4b20482617f32995d3b20569557..8ca650d00f0c23e88ee35d86c81766fe23330c7d 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -2989,15 +2989,16 @@ class V8_EXPORT Object : public Value {
Local<Value> key);
V8_DEPRECATE_SOON("Use maybe version", bool Delete(Local<Value> key));
- // TODO(dcarney): mark V8_WARN_UNUSED_RESULT
- Maybe<bool> Delete(Local<Context> context, Local<Value> key);
+ V8_WARN_UNUSED_RESULT Maybe<bool> Delete(Local<Context> context,
+ Local<Value> key);
V8_DEPRECATED("Use maybe version", bool Has(uint32_t index));
- V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context, uint32_t index);
+ V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context,
+ uint32_t index);
V8_DEPRECATED("Use maybe version", bool Delete(uint32_t index));
- // TODO(dcarney): mark V8_WARN_UNUSED_RESULT
- Maybe<bool> Delete(Local<Context> context, uint32_t index);
+ V8_WARN_UNUSED_RESULT Maybe<bool> Delete(Local<Context> context,
+ uint32_t index);
V8_DEPRECATED("Use maybe version",
bool SetAccessor(Local<String> name,
@@ -3013,8 +3014,8 @@ class V8_EXPORT Object : public Value {
Local<Value> data = Local<Value>(),
AccessControl settings = DEFAULT,
PropertyAttribute attribute = None));
- // TODO(dcarney): mark V8_WARN_UNUSED_RESULT
- Maybe<bool> SetAccessor(Local<Context> context, Local<Name> name,
+ V8_WARN_UNUSED_RESULT Maybe<bool> SetAccessor(Local<Context> context,
+ Local<Name> name,
AccessorNameGetterCallback getter,
AccessorNameSetterCallback setter = 0,
MaybeLocal<Value> data = MaybeLocal<Value>(),
@@ -3746,12 +3747,12 @@ class V8_EXPORT Promise : public Object {
* Ignored if the promise is no longer pending.
*/
V8_DEPRECATE_SOON("Use maybe version", void Resolve(Local<Value> value));
- // TODO(dcarney): mark V8_WARN_UNUSED_RESULT
- Maybe<bool> Resolve(Local<Context> context, Local<Value> value);
+ V8_WARN_UNUSED_RESULT Maybe<bool> Resolve(Local<Context> context,
+ Local<Value> value);
V8_DEPRECATE_SOON("Use maybe version", void Reject(Local<Value> value));
- // TODO(dcarney): mark V8_WARN_UNUSED_RESULT
- Maybe<bool> Reject(Local<Context> context, Local<Value> value);
+ V8_WARN_UNUSED_RESULT Maybe<bool> Reject(Local<Context> context,
+ Local<Value> value);
V8_INLINE static Resolver* Cast(Value* obj);
« no previous file with comments | « no previous file | src/wasm/wasm-js.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698