Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2135853002:
[DevTools] Better heuristic for detecting object literals. (Closed)
|
Created:
4 years, 5 months ago by dgozman Modified:
4 years, 5 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Better heuristic for detecting object literals.
Improved heuristic for detecting object literals. Previously valid
blocks were detected as object literals and wrapped in parentheses.
Based on the patch by zirakertan@gmail.com: https://codereview.chromium.org/1875903002/
BUG=499864, 603890
NOTRY=true
Committed: https://crrev.com/fdaeccea42f63fa0836a814a80b02ac71433d385
Cr-Commit-Position: refs/heads/master@{#404819}
Patch Set 1 #
Messages
Total messages: 29 (13 generated)
dgozman@chromium.org changed reviewers: + kozyatinskiy@chromium.org, paulirish@chromium.org
Take a look please. Following up on unfinished external contribution.
lgtm
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
thanks for taking this over and getting it in
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== [DevTools] Better heuristic for detecting object literals. Improved heuristic for detecting object literals. Previously valid blocks were detected as object literals and wrapped in parentheses. Based on the patch by zirakertan@gmail.com: https://codereview.chromium.org/1875903002/ BUG=499864, 603890 ========== to ========== [DevTools] Better heuristic for detecting object literals. Improved heuristic for detecting object literals. Previously valid blocks were detected as object literals and wrapped in parentheses. Based on the patch by zirakertan@gmail.com: https://codereview.chromium.org/1875903002/ BUG=499864, 603890 NOTRY=true ==========
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Better heuristic for detecting object literals. Improved heuristic for detecting object literals. Previously valid blocks were detected as object literals and wrapped in parentheses. Based on the patch by zirakertan@gmail.com: https://codereview.chromium.org/1875903002/ BUG=499864, 603890 NOTRY=true ========== to ========== [DevTools] Better heuristic for detecting object literals. Improved heuristic for detecting object literals. Previously valid blocks were detected as object literals and wrapped in parentheses. Based on the patch by zirakertan@gmail.com: https://codereview.chromium.org/1875903002/ BUG=499864, 603890 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Better heuristic for detecting object literals. Improved heuristic for detecting object literals. Previously valid blocks were detected as object literals and wrapped in parentheses. Based on the patch by zirakertan@gmail.com: https://codereview.chromium.org/1875903002/ BUG=499864, 603890 NOTRY=true ========== to ========== [DevTools] Better heuristic for detecting object literals. Improved heuristic for detecting object literals. Previously valid blocks were detected as object literals and wrapped in parentheses. Based on the patch by zirakertan@gmail.com: https://codereview.chromium.org/1875903002/ BUG=499864, 603890 NOTRY=true Committed: https://crrev.com/fdaeccea42f63fa0836a814a80b02ac71433d385 Cr-Commit-Position: refs/heads/master@{#404819} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fdaeccea42f63fa0836a814a80b02ac71433d385 Cr-Commit-Position: refs/heads/master@{#404819} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
